Skip to content

Conversation

@fin09pcap
Copy link
Member

@fin09pcap fin09pcap commented Oct 26, 2025

Problem Statement

When performing secret operations; the go routines for the workers would hide the errors raised during the operation(s).

Changes

The following changes are proposed.

1) Exporter and Importer Logging Enhancements

  • Added operation timing, start/completion logs with metrics
  • Implemented semaphore acquisition logging with detailed context error diagnostics
  • Added producer/consumer progress tracking and rate metrics (paths/sec, processed counts)
  • Implemented error classification (connection, permission, timeout) for Vault read failures
  • Added context cancellation detection and early error reporting
  • Fixed context error validation using errors.Is() instead of == equality checks
  • Ensures proper detection of context.Canceled and context.DeadlineExceeded with wrapped errors

2) Test Coverage (importer_test.go)

  • Added constructor validation tests
  • Added bundle analysis tests for covering edge cases and metric calculations

@fin09pcap fin09pcap self-assigned this Oct 26, 2025
@fin09pcap fin09pcap marked this pull request as ready for review November 19, 2025 00:56
@fin09pcap fin09pcap requested a review from a team as a code owner November 19, 2025 00:56
@fin09pcap fin09pcap merged commit d3bc722 into elastic:main Nov 20, 2025
13 of 14 checks passed
@fin09pcap fin09pcap deleted the add_semaphore_logging_for_errors branch November 20, 2025 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants