mimecast: fix parsing of logon-authentication-failed events #11638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efd6
added
Integration:mimecast
Some of the test cases are altered as their provenance is not provided and they do not look like they are valid.
🚀 Benchmarks reportTo see the full report comment with |
💚 Build Succeeded
cc @efd6 |
|
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
efd6
commented
Nov 5, 2024
| @@ -470,21 +470,6 @@ | |||
| }, | |||
| { | |||
| "@timestamp": "2021-10-11T14:46:10.000Z", | |||
| "client": { | |||
There was a problem hiding this comment.
This is remove since previously the field labelled "remote IP" was being assigned to client.ip.
Comment on lines
+30
to
+31
| {"id":"eNqrVipOTS4tSs1MUbJSMvCrMHX2MzL1yLFITjJNd8rO9wiJyAlL89c2DXZ1C3eP9AyvijKL9I7Rd_WOzC0ztMg2dzFM1M73s6w09CqoDA1T0lFKLE3JLMnJTwcZaGxoaWxsaGRkoKOUXFpckp-bWpScn5IKtMnZxMzR3BSovCy1qDgzP0_JyrAWAPktKzg","auditType":"Logon Authentication Failed","user":"[email protected]","eventTime":"2021-10-12T08:47:55+0000","eventInfo": "User [email protected] attempted to access the mimecast-matfe but does not have the required permissions to do so, Date: 2022-03-29, Time: 13:31:03+0000, IP: 67.43.156.15, Application: API, Remote IP is 67.43.156.15","category":"authentication_logs"} | ||
| {"id":"eNqrVipOTS4tSs1MUbJSMvCrMHX2MzL1yLFITjJNd8rO9wiJyAlL89c2DXZ1C3eP9AyvijKL9I7Rd_WOzC0ztMg2dzFM1M73s6w09CqoDA1T0lFKLE3JLMnJTwcZaGxoaWxsaGRkoKOUXFpckp-bWpScn5IKtMnZxMzR3BSovCy1qDgzP0_JyrAWAPktKzg","auditType":"Logon Authentication Failed","user":"[email protected]","eventTime":"2021-10-12T08:47:55+0000","eventInfo": "Failed authentication for [email protected] <John Doe>, Date: 2022-03-29, Time: 19:33:05 BTT, IP: 67.43.156.15, Application: SMTP-MTA2, Reason: Account locked","category":"authentication_logs"} |
There was a problem hiding this comment.
Spaces before :'s removed, lonely : removed, duplicate , removed.
| patterns: | ||
| - '^%{GREEDYDATA:mimecast.info},\sDate:\s%{DATE:mimecast.date},\sTime:\s%{TIME:mimecast.time} %{TIMEZONE:mimecast.timezone},\sIP:\s%{IP:client.ip},\sApplication:\s%{NOTSPACE:mimecast.application},(?:\sMethod:\s%{DATA:mimecast.method},)?\sReason:\s%{DATA:event.reason}$' | ||
| - '^%{GREEDYDATA:mimecast.info},\sDate:\s%{DATE:mimecast.date},\sTime:\s%{TIME:mimecast.time}%{TIMEZONE:mimecast.timezone},\sIP:\s%{IP:client.ip},\sApplication:\s%{NOTSPACE:mimecast.application},\sRemote IP is %{IP:mimecast.remote_ip}$' | ||
| - '^%{GREEDYDATA:mimecast.info},\s%{WORD} ?: ?%{DATA:mimecast.email.address}\[%{DATA:mimecast.email.metadata}\] remote IP ?: ?%{IP:mimecast.remote_ip} application ?: ?%{NOTSPACE:mimecast.application}$' |
There was a problem hiding this comment.
I have significant doubt about the flexibility that's implemented here, but it is there because of the apparently free-form nature of the only example like this.
|
Note AUTOMERGE ENABLED: IF YOU NEED CHANGES DO NOT APPROVE |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Some of the test cases are altered as their provenance is not provided and they do not look like they are valid.
Note
I think more work should be done in this area, but this is left as future work; this change fixes a bug.
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots