Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[checkpoint_harmony_endpoint] Tidy the Server URL var, screenshots #11652

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[checkpoint_harmony_endpoint] Tidy the Server URL var, screenshots #11652

wants to merge 5 commits into from

Conversation

chrisberkhout
Copy link
Contributor

@chrisberkhout chrisberkhout commented Nov 6, 2024 •
edited
Loading

Proposed commit message

[checkpoint_harmony_endpoint] Tidy the Server URL var, screenshots

Don't use the EU server as a default for base_url.

Update the Add Integration screenshot and move it after the dashboard
screenshot.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

@chrisberkhout chrisberkhout added bugfix Pull request that fixes a bug issue Integration:checkpoint_harmony_endpoint Check Point Harmony Endpoint labels Nov 6, 2024
@chrisberkhout chrisberkhout self-assigned this Nov 6, 2024
@chrisberkhout chrisberkhout requested a review from a team as a code owner November 6, 2024 15:03
@chrisberkhout chrisberkhout added the Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations] label Nov 6, 2024
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

chemamartinez
chemamartinez approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@chemamartinez chemamartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a small typo in the PR link.

packages/checkpoint_harmony_endpoint/changelog.yml Outdated Show resolved Hide resolved
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Nov 6, 2024 •
edited
Loading

🚀 Benchmarks report

Package checkpoint_harmony_endpoint 👍(3) 💚(2) 💔(2)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
antibot 2777.78 1636.66 -1141.12 (-41.08%) 💔
zerophishing 5917.16 4166.67 -1750.49 (-29.58%) 💔

To see the full report comment with /test benchmark fullreport

@chrisberkhout chrisberkhout changed the title [checkpoint_harmony_endpoint] Dashboard screenshot first [checkpoint_harmony_endpoint] Tidy the Server URL var, screenshots Nov 6, 2024
@chrisberkhout
Copy link
Contributor Author

@chemamartinez Sorry, one more change in here. The default Server URL was the EU server. I removed the default and put examples for US and EU in the description.

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @chrisberkhout

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chemamartinez chemamartinez Awaiting requested review from chemamartinez

Assignees

@chrisberkhout chrisberkhout

Labels
bugfix Pull request that fixes a bug issue Integration:checkpoint_harmony_endpoint Check Point Harmony Endpoint Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chrisberkhout @elasticmachine @chemamartinez