-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GCP VertexAI] Update dashboard and documentation & Fix field mapping #11659
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few editing suggestions, otherwise LGTM.
Quality Gate failedFailed conditions |
💚 Build Succeeded
History
cc @muthu-mps |
{ | ||
"cloud": { | ||
"provider": "gcp", | ||
"account": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sample event is directly taken from Kibana, right ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, The sample event is from the ingested document and not a generated one from system test.
@@ -3,8 +3,32 @@ | |||
"controlGroupInput": { | |||
"chainingSystem": "HIERARCHICAL", | |||
"controlStyle": "oneLine", | |||
"ignoreParentSettingsJSON": "{\"ignoreFilters\":false,\"ignoreQuery\":false,\"ignoreTimerange\":false,\"ignoreValidations\":false}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you mention whats the change here ?
Its hard to understand from the json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The JSON got beautified while running the elastic-package check
command. There is no changes to the dashboard other than the title.
This PR enhances the documentation with the additional informations.
Change the title LLM deployment in the dashboard visualisations to model deployment.
Add
ECS reference
and includegcp.labels.*
fields to the fields.yml.Checklist
changelog.yml
file.Author's Checklist
The document covers the roles & permissions, configuration and troubleshooting section. Also follows the documentation guidelines.
Related issues
Screenshots