Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GCP VertexAI] Update dashboard and documentation & Fix field mapping #11659

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

muthu-mps
Copy link
Contributor

@muthu-mps muthu-mps commented Nov 7, 2024

  • Enhancement

This PR enhances the documentation with the additional informations.

  • Add roles & permissions section
  • Include sample metrics document
  • Add configuration & troubleshooting sections.

Change the title LLM deployment in the dashboard visualisations to model deployment.

Add ECS reference and include gcp.labels.* fields to the fields.yml.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

The document covers the roles & permissions, configuration and troubleshooting section. Also follows the documentation guidelines.

Related issues

Screenshots

gcp-vertexai-overview-dashboard

@muthu-mps muthu-mps added Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] Integration:gcp_vertexai GCP Vertex AI labels Nov 7, 2024
@muthu-mps muthu-mps self-assigned this Nov 7, 2024
@muthu-mps muthu-mps changed the title [GCP VertexAI] Update dashboard and documentation [GCP VertexAI] Update dashboard and documentation & Fix field mapping Nov 7, 2024
@muthu-mps muthu-mps marked this pull request as ready for review November 7, 2024 10:49
@muthu-mps muthu-mps requested a review from a team as a code owner November 7, 2024 10:49
@andrewkroh andrewkroh added dashboard Relates to a Kibana dashboard bug, enhancement, or modification. enhancement New feature or request labels Nov 7, 2024
Copy link
Contributor

@alaudazzi alaudazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few editing suggestions, otherwise LGTM.

packages/gcp_vertexai/_dev/build/docs/README.md Outdated Show resolved Hide resolved
packages/gcp_vertexai/_dev/build/docs/README.md Outdated Show resolved Hide resolved
packages/gcp_vertexai/_dev/build/docs/README.md Outdated Show resolved Hide resolved
packages/gcp_vertexai/_dev/build/docs/README.md Outdated Show resolved Hide resolved
packages/gcp_vertexai/_dev/build/docs/README.md Outdated Show resolved Hide resolved
packages/gcp_vertexai/_dev/build/docs/README.md Outdated Show resolved Hide resolved
packages/gcp_vertexai/_dev/build/docs/README.md Outdated Show resolved Hide resolved
packages/gcp_vertexai/_dev/build/docs/README.md Outdated Show resolved Hide resolved
packages/gcp_vertexai/_dev/build/docs/README.md Outdated Show resolved Hide resolved
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
68.4% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @muthu-mps

{
"cloud": {
"provider": "gcp",
"account": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sample event is directly taken from Kibana, right ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, The sample event is from the ingested document and not a generated one from system test.

@@ -3,8 +3,32 @@
"controlGroupInput": {
"chainingSystem": "HIERARCHICAL",
"controlStyle": "oneLine",
"ignoreParentSettingsJSON": "{\"ignoreFilters\":false,\"ignoreQuery\":false,\"ignoreTimerange\":false,\"ignoreValidations\":false}",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you mention whats the change here ?
Its hard to understand from the json

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The JSON got beautified while running the elastic-package check command. There is no changes to the dashboard other than the title.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dashboard Relates to a Kibana dashboard bug, enhancement, or modification. enhancement New feature or request Integration:gcp_vertexai GCP Vertex AI Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants