Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSPM: add cloud connectors support #11663

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

moukoublen
Copy link
Member

@moukoublen moukoublen commented Nov 7, 2024

Proposed commit message

Add new template URL for cloudformation creates the cloud connectors remote role.
Add a new bool variable indicating that cloud connectors are used in the integration. Cloudbeat should parse this boolean.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@moukoublen moukoublen self-assigned this Nov 7, 2024
@moukoublen moukoublen added the Team:Cloud Security Label for the Cloud Security team [elastic/cloud-security-posture] label Nov 7, 2024
@andrewkroh andrewkroh added the Integration:cloud_security_posture Security Posture Management label Nov 7, 2024
@elastic-vault-github-plugin-prod

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@moukoublen moukoublen marked this pull request as ready for review November 8, 2024 10:01
@moukoublen moukoublen requested a review from a team as a code owner November 8, 2024 10:01
@@ -9,6 +9,11 @@
# 1.4.x - 8.9.x
# 1.3.x - 8.8.x
# 1.2.x - 8.7.x
- version: "1.11.0-preview14"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want this change in 8.16 ? as we didn't test 8.16 with this change, maybe it would be safer to have in in 1.12.x?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right; I forgot we still need to bump to 8.17.
This means I should merge after we bump the stable 1.11.0 to create the 1.12.0-preview1. (otherwise, it would be a bit more complicated to produce the stable 1.11.0 release with a backport branch).

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @moukoublen

@andrewkroh andrewkroh added the enhancement New feature or request label Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:cloud_security_posture Security Posture Management Team:Cloud Security Label for the Cloud Security team [elastic/cloud-security-posture]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants