-
Notifications
You must be signed in to change notification settings - Fork 457
[CI] Add support to test packages with basic subscription #13377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Verbose mode allows us to show the full description of the issue that it is going to be created or updated.
🚀 Benchmarks reportTo see the full report comment with |
d87ae20
to
fcfc90a
Compare
@@ -1,12 +1,17 @@ | |||
{{ if ne .stackVersion "" -}} | |||
- Stack version: {{ .stackVersion }} | |||
{{ else -}} | |||
- Stack version: Same as in Pull Request builds |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This value could be changed in the follow-up PR to include LogsDB too.
if ! reason=$(mage -d "${WORKSPACE}" -w . isSubscriptionCompatible) ; then | ||
return 1 | ||
fi | ||
echo "${reason}" | ||
return 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would return failure if there is any failure (e.g. failed to read YAML file), and success in any other case (zero value).
When it returns success, the message echoed will show whether or not it is compatible (true or false).
if ! compatible=$(is_subscription_compatible); then | ||
echo "${FATAL_ERROR}" | ||
return 1 | ||
fi | ||
if [[ "${compatible}" == "false" ]]; then | ||
echo "[${package}] PR is not affected: subscription not compatible with ${ELASTIC_SUBSCRIPTION}" | ||
return 1 | ||
fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For both cases, this function will return failure (code 1). Depending on the message echoed, the caller method should take one or other action.
💛 Build succeeded, but was flaky
Failed CI StepsHistory
cc @mrodm |
To be added in elastic#13484
|
Proposed commit message
Update CI scripts and tools (
ReportFailedTests
) to allow run Elastic stack with other subscriptions.Currently, it is just supported "basic" and "trial".
Added new mage targets to get the subscription set in the package:
Author's Checklist
go.mod
,go.sum
and.buildkite/scripts/common.sh
.How to test this PR locally
Related issues