Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

okta: retain full email address as user.name #13404

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Apr 3, 2025

Proposed commit message

okta: retain full email address as user.name

The entityanalytics_okta integration retains the full email address
rather than only the username part of the address. This breaks being
able to correlate individual entities with events, in addition to
potentially allowing collision between non-identitical users in events.
So simplify the code and just keep the whole thing.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added enhancement New feature or request Integration:okta Okta Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Apr 3, 2025
@efd6 efd6 self-assigned this Apr 3, 2025
The entityanalytics_okta integration retains the full email address
rather than only the username part of the address. This breaks being
able to correlate individual entities with events, in addition to
potentially allowing collision between non-identitical users in events.
So simplify the code and just keep the whole thing.
@elastic-vault-github-plugin-prod

🚀 Benchmarks report

Package okta 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
system 1265.82 1028.81 -237.01 (-18.72%) 💔

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

cc @efd6

@efd6 efd6 marked this pull request as ready for review April 3, 2025 03:21
@efd6 efd6 requested a review from a team as a code owner April 3, 2025 03:21
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:okta Okta Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants