Logstash fix health report conditional cel logic #13416
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💚 Build Succeeded
|
kaisecheng
reviewed
Apr 4, 2025
| @@ -47,8 +47,8 @@ program: | | |||
| "id":pipeline_name, | |||
| "status":pipeline.status, | |||
| "symptom":pipeline.symptom, | |||
| "state":pipeline.details.status.state, | |||
| "flow": pipeline.details.flow, | |||
| "state": has(pipeline.details.status.state) ? pipeline.details.status.state : {}, | |||
There was a problem hiding this comment.
state could be LOADING, RUNNING, FINISHED or TERMINATED
I am wondering should the default be an empty string "" instead of empthy hash {}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Check for pipeline.details for flow and state in cel for health report datastream to handle "unknown" status
Checklist
changelog.ymlfile.How to test this PR locally
Use of logstash integration no longer has cel parsing failures
Related issues
Screenshots