Skip to content

feat(apm): set secret=true for secret_token #14147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(apm): set secret=true for secret_token #14147

wants to merge 1 commit into from

Conversation

kruskall
Copy link
Member

@kruskall kruskall commented Jun 4, 2025

Proposed commit message

set secret=true for apm secret_token

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Closes elastic/apm-server#11450

Screenshots

@kruskall kruskall requested a review from a team as a code owner June 4, 2025 15:11
@kruskall kruskall added the enhancement New feature or request label Jun 4, 2025
simitt
simitt approved these changes Jun 4, 2025
View reviewed changes
Copy link
Contributor

@simitt simitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please align with the Fleet/APM UI team to ensure the onboarding changes are considered in the same stack version.

@elasticmachine
Copy link

💚 Build Succeeded

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@andrewkroh andrewkroh added the Integration:apm Elastic APM label Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simitt simitt simitt approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request Integration:apm Elastic APM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Obfuscate secret token after removing Fleet's ability to read secrets
4 participants
@kruskall @elasticmachine @simitt @andrewkroh