Skip to content

[Akamai] - Added initial interval restrictions for api requests #15649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 15, 2025
Merged

[Akamai] - Added initial interval restrictions for api requests #15649

merged 7 commits into from
Oct 15, 2025
+23 −6

Conversation

ShourieG
Copy link
Contributor

@ShourieG ShourieG commented Oct 14, 2025 •
edited
Loading

Type of change

  • Bug

Proposed commit message

Added initial interval restrictions for api requests and 
updated the default interval value, documentation accordingly.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@ShourieG ShourieG self-assigned this Oct 14, 2025
@ShourieG ShourieG added documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. Integration:akamai Akamai (Community supported) bugfix Pull request that fixes a bug issue Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Oct 14, 2025
@ShourieG ShourieG requested a review from efd6 October 14, 2025 13:38
@ShourieG ShourieG marked this pull request as ready for review October 14, 2025 13:41
@ShourieG ShourieG requested a review from a team as a code owner October 14, 2025 13:41
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@ShourieG ShourieG added the enhancement New feature or request label Oct 14, 2025
@narph
Copy link
Contributor

narph commented Oct 14, 2025

@ShourieG can we take on the Updated the stack version to avoid health status degraded issue. in a different PR when we confirm the fix worked?

@ShourieG
Copy link
Contributor Author

ShourieG commented Oct 14, 2025 •
edited
Loading

@ShourieG can we take on the Updated the stack version to avoid health status degraded issue. in a different PR when we confirm the fix worked?

Sure, but then we have to skip system tests for now.
Update: reverted the stack bump and skipped system tests.

@ShourieG ShourieG removed the enhancement New feature or request label Oct 14, 2025
efd6
efd6 reviewed Oct 14, 2025
View reviewed changes
packages/akamai/data_stream/siem/manifest.yml Outdated
default: 24h
description: Initial interval to poll for events. Default is 24 hours. Supported units for this parameter are h/m/s.
default: 12h
description: Initial interval to poll for events. Default is 12 hours. Supported units for this parameter are h/m/s.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: Initial interval to poll for events. Default is 12 hours. Supported units for this parameter are h/m/s.
description: Initial interval to poll for events. Default is the maximum allowed value of 12 hours. Supported units for this parameter are h/m/s.

packages/akamai/_dev/build/docs/README.md Outdated
- The GCS input currently does not support fetching of buckets using bucket prefixes, so the bucket names have to be configured manually for each data stream.
- The GCS input currently only accepts a service account JSON key or a service account JSON file for authentication.
- The GCS input currently only supports JSON data.
- The [Akamai SIEM Integration API](https://techdocs.akamai.com/siem-integration/reference/api) has a maximum look-back interval limit of 12 hours. Any value configured beyond this will be automatically ignored in order to avoid API errors.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is needed here, or at least if it is added here, it should also be added at the config UI. Information locality is important.

packages/akamai/data_stream/siem/agent/stream/httpjson.yml.hbs Outdated
Comment on lines 28 to 32
[[- if (gt $maxLookbackTime $initialTime) -]]
[[- $maxLookbackTime -]]
[[- else -]]
[[- $initialTime -]]
[[- end -]]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[[- if (gt $maxLookbackTime $initialTime) -]]
[[- $maxLookbackTime -]]
[[- else -]]
[[- $initialTime -]]
[[- end -]]
[[- max $maxLookbackTime $initialTime -]]

@ShourieG
Copy link
Contributor Author

@efd6, addressed all comments.

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @ShourieG

@ShourieG ShourieG merged commit 596fe16 into elastic:main Oct 15, 2025
7 checks passed
@elastic-vault-github-plugin-prod
Copy link

Package akamai - 2.28.1 containing this change is available at https://epr.elastic.co/package/akamai/2.28.1/

@andrewkroh andrewkroh removed the documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. label Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@efd6 efd6 efd6 approved these changes

Assignees

@ShourieG ShourieG

Labels

bugfix Pull request that fixes a bug issue Integration:akamai Akamai (Community supported) Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ShourieG @elasticmachine @narph @efd6 @andrewkroh