-
Notifications
You must be signed in to change notification settings - Fork 511
[windows/perfmon] - Expose match_by_parent_instance option for perfmon #15763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: Denis <[email protected]>
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
|
Pinging @elastic/sec-windows-platform (Team:Security-Windows Platform) |
🚀 Benchmarks reportPackage
|
| Data stream | Previous EPS | New EPS | Diff (%) | Result |
|---|---|---|---|---|
applocker_exe_and_dll |
6134.97 | 4545.45 | -1589.52 (-25.91%) | 💔 |
applocker_packaged_app_execution |
12195.12 | 9803.92 | -2391.2 (-19.61%) | 💔 |
forwarded |
1221 | 928.51 | -292.49 (-23.95%) | 💔 |
windows_defender |
11363.64 | 9615.38 | -1748.26 (-15.38%) | 💔 |
To see the full report comment with /test benchmark fullreport
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need testing steps in the description that would demonstrate that the rendered Filebeat configuration (can be acquired from Elastic Agent Diagnostics, path ./components/*/beat-rendered-config.yml) contains the right option in the right place.
|
@rdner Thanks! I'll attach some screenshots as well. I have them on my windows but it's not booting up. I'll update you once i do it. |
|
@rdner I've attached the screenshots to the PR description and added testing steps. |
💚 Build Succeeded
History
|
Proposed commit message
Add match_by_parent_instance option to windows perfmon datastream.
This option defaults to
truebecause it is enabled by default in beats.Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
elastic-package buildwindows.perfmon.instancevalues in default mode (It should showsvchost,connhostetc.)match_parent_by_instanceboolean and update the policywindows.perfmon.instancevalues in default mode (you should seesvchost#1,svchost#2,connhost#2etc.)Related issues
Screenshots
The option on integrations page
Instance names with
match_by_parent_instanceenabled (default)Instance names with
match_by_parent_instancedisabledbeat_rendered_config.yaml