Skip to content

Conversation

@MakoWish
Copy link
Contributor

@MakoWish MakoWish commented Nov 6, 2025

Type of change

  • Enhancement

Proposed commit message

This is an initial push for a new Integration Faitour: MakoWish/Faitour

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • Separate application logging from honeypot event logging for distinct datasets
  • Dashboards will be created once the beta is released and available

Notes

See #13304 for additional conversation on this one. I needed to refactor the logging into two different file sets for distinct datasets in Elastic, and I finally found the time to get that done.

MakoWish and others added 19 commits March 25, 2025 09:39
Commit suggested changes to README.md from code review.

Co-authored-by: Dan Kortschak <[email protected]>
Commit suggested change to changelog.yml from code review.

Co-authored-by: Dan Kortschak <[email protected]>
@andrewkroh andrewkroh added New Integration Issue or pull request for creating a new integration package. documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. labels Nov 6, 2025
@MakoWish MakoWish marked this pull request as ready for review November 6, 2025 21:57
@MakoWish MakoWish requested a review from a team as a code owner November 6, 2025 21:57
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a base64 encoded png at 900×900. I think we could downsize this a little since the icons in the UI are never rendered at that resolution. It looks like 150×150 should be plenty.

# newer versions go on top
- version: "0.0.1"
changes:
- description: Initial draft of the package
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- description: Initial draft of the package
- description: Initial draft of the package.

changes:
- description: Initial draft of the package
type: enhancement
link: https://github.com/elastic/integrations/pull/13304
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
link: https://github.com/elastic/integrations/pull/13304
link: https://github.com/elastic/integrations/pull/15889

################################
## Redact passwords if tagged ##
################################
- redact:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will fail in tests running for basic license, so please replace this with gsub; you can get exactly the same functionality with that processor.

## Handle Pipeline Failures ##
##############################
on_failure:
- append:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- append:
- set:

@@ -0,0 +1,41 @@
title: "Application Logs"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
title: "Application Logs"
title: "Faitour Application Logs"

?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comments as above.

@@ -0,0 +1,50 @@
title: "Honeypot Events"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
title: "Honeypot Events"
title: "Faitour Honeypot Events"

?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
type: elastic
type: community

(or "partner" depending on arrangement)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've changed the general structure of the READMEs, so it would be good to update this to match. @alaudazzi can you provide guidance for that here?

@efd6
Copy link
Contributor

efd6 commented Nov 6, 2025

/test

@elastic-vault-github-plugin-prod

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. New Integration Issue or pull request for creating a new integration package.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants