-
Notifications
You must be signed in to change notification settings - Fork 511
[Faitour Honeypot] Initial Push of Beta Integration #15889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Commit suggested changes to README.md from code review. Co-authored-by: Dan Kortschak <[email protected]>
Commit suggested change to changelog.yml from code review. Co-authored-by: Dan Kortschak <[email protected]>
Co-authored-by: Dan Kortschak <[email protected]>
Co-authored-by: Dan Kortschak <[email protected]>
…common-config.yml Co-authored-by: Dan Kortschak <[email protected]>
…common-config.yml Co-authored-by: Dan Kortschak <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a base64 encoded png at 900×900. I think we could downsize this a little since the icons in the UI are never rendered at that resolution. It looks like 150×150 should be plenty.
| # newer versions go on top | ||
| - version: "0.0.1" | ||
| changes: | ||
| - description: Initial draft of the package |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - description: Initial draft of the package | |
| - description: Initial draft of the package. |
| changes: | ||
| - description: Initial draft of the package | ||
| type: enhancement | ||
| link: https://github.com/elastic/integrations/pull/13304 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| link: https://github.com/elastic/integrations/pull/13304 | |
| link: https://github.com/elastic/integrations/pull/15889 |
| ################################ | ||
| ## Redact passwords if tagged ## | ||
| ################################ | ||
| - redact: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will fail in tests running for basic license, so please replace this with gsub; you can get exactly the same functionality with that processor.
| ## Handle Pipeline Failures ## | ||
| ############################## | ||
| on_failure: | ||
| - append: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - append: | |
| - set: |
| @@ -0,0 +1,41 @@ | |||
| title: "Application Logs" | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| title: "Application Logs" | |
| title: "Faitour Application Logs" |
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comments as above.
| @@ -0,0 +1,50 @@ | |||
| title: "Honeypot Events" | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| title: "Honeypot Events" | |
| title: "Faitour Honeypot Events" |
?
packages/faitour/manifest.yml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| type: elastic | |
| type: community |
(or "partner" depending on arrangement)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've changed the general structure of the READMEs, so it would be good to update this to match. @alaudazzi can you provide guidance for that here?
|
/test |
🚀 Benchmarks reportTo see the full report comment with |
💚 Build Succeeded
|
Type of change
Proposed commit message
This is an initial push for a new Integration
Faitour: MakoWish/FaitourChecklist
changelog.ymlfile.Author's Checklist
Notes
See #13304 for additional conversation on this one. I needed to refactor the logging into two different file sets for distinct datasets in Elastic, and I finally found the time to get that done.