-
Notifications
You must be signed in to change notification settings - Fork 518
fix: Rename exclude_fields and include_fields to match Qualys API expected fields #16217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
clement-fouque
wants to merge
6
commits into
main
Choose a base branch
from
15159-qualys_gav-add-excludefields-and-includefields-in-the-configuration
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix: Rename exclude_fields and include_fields to match Qualys API expected fields #16217
clement-fouque
wants to merge
6
commits into
main
from
15159-qualys_gav-add-excludefields-and-includefields-in-the-configuration
+374
−467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d-excludefields-and-includefields-in-the-configuration
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
🚀 Benchmarks reportTo see the full report comment with |
💚 Build Succeeded
History
|
Contributor
Author
|
@elastic/security-service-integrations it's ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bugfix
Pull request that fixes a bug issue
documentation
Improvements or additions to documentation. Applied to PRs that modify *.md files.
Integration:qualys_gav
Qualys Global AssetView
Team:Security-Service Integrations
Security Service Integrations team [elastic/security-service-integrations]
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
This pull request updates the Qualys Global AssetView integration to version
0.6.1and primarily addresses a bug related to API field naming conventions. The main focus is on correcting the field names used in API requests to match the expected Qualys API parameters. Additionally, minor formatting improvements are included.Bugfixes and API compatibility
packages/qualys_gav/data_stream/asset/agent/stream/cel.yml.hbsto useexcludeFieldsandincludeFieldsinstead of the incorrectexclude_fieldsandinclude_fields, ensuring proper API request formatting.Documentation and metadata
packages/qualys_gav/changelog.ymlto document the bugfix and link to the related pull request.0.6.1inpackages/qualys_gav/manifest.yml.Formatting improvements
packages/qualys_gav/_dev/deploy/docker/files/config.ymlfrom|to|-for thebodyfield, which affects trailing newline handling.Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots