Skip to content

[cisco_meraki_metrics] Remove rsrp and rsrq metrics if no values present #16223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[cisco_meraki_metrics] Remove rsrp and rsrq metrics if no values present #16223

wants to merge 1 commit into from

Conversation

@gpop63
Copy link
Contributor

@gpop63 gpop63 commented Dec 3, 2025

Overview

This PR removes rsrp and rsrq metrics if no actual numerical values are present.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@gpop63 gpop63 self-assigned this Dec 3, 2025
@gpop63 gpop63 added Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] Integration:cisco_meraki_metrics Cisco Meraki Metrics labels Dec 3, 2025
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Dec 3, 2025

🚀 Benchmarks report

Package cisco_meraki_metrics 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
device_health 15625 7194.24 -8430.76 (-53.96%) 💔

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

elasticmachine commented Dec 3, 2025

💚 Build Succeeded

cc @gpop63

@gpop63 gpop63 marked this pull request as ready for review December 3, 2025 17:29
@gpop63 gpop63 requested a review from a team as a code owner December 3, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tommyers-elastic tommyers-elastic Awaiting requested review from tommyers-elastic

At least 1 approving review is required to merge this pull request.

Assignees

@gpop63 gpop63

Labels

Integration:cisco_meraki_metrics Cisco Meraki Metrics Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gpop63 @elasticmachine