[Chargeback] Alerting rule #16228
Closed
[Chargeback] Alerting rule #16228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m_color_blind palate. Add ECU rate to the dashboard.
…cater for large organisations.
…ow exactly what the output be.
…Also added explanation about the rest of the config.
…f both, to make it easier to identify the deployment in the dashboard.
…okup index automatically when installing the package.
* dashboard control * updating version + DV
* adding sku and cost_type to billing data for node granularity * working on sku with pipeline to do parsing * downplaying version * transform
…16185) * Add deployment_group extraction from ESS Billing tags - Extract chargeback_group tag value to deployment_group field in billing pipeline - Add deployment_group to billing_cluster_cost transform group_by - Add deployment_group field definition - Fix transforms to use elasticsearch.cluster.name without .keyword - Update changelog for v0.2.4 * Add deployment_group extraction using runtime mappings from ESS Billing tags * Update dashboard with deployment_group filter and definitions * Bump version to 0.2.5 for deployment_group feature after merging SKU/cost_type changes * known [bug](elastic/elasticsearch-chargeback#60) from 0.2.4
* adding sku and cost_type to billing data for node granularity * working on sku with pipeline to do parsing * downplaying version * transform * merge * dashboard * setting version
* Add observability alerts for chargeback integration - Add two ES|QL alerting rules: detect new chargeback groups and detect deployments missing usage data - Add comprehensive documentation for alert setup and configuration - Update Elasticsearch version requirement to 9.2.0+ for smart lookup join support - Add transform startup and monitoring instructions to README * Update changelog with PR #16205 * Remove wrong information * Update chargeback README documentation * Improve observability alert action message formatting * Clarify configuration update vs add new period documentation
- Add 3 Kibana alerting rule templates: - Transform health monitoring for all Chargeback transforms - New chargeback group detection - Deployment with missing usage data detection - Enable auto-start for all transforms (start: true in manifests) - Update transform pipeline references to version 0.2.8 - Add performance warning about initial transform execution - Update README with alerting documentation - Bump package version to 0.2.8
Author
|
Sorry, wrong branch |
There was a problem hiding this comment.
Pull request overview
This PR adds alerting rule templates to the Chargeback integration for monitoring transform health and data quality issues. The integration now includes three pre-configured alert rule templates that can be installed from Kibana: transform health monitoring, new chargeback group detection, and missing usage data detection.
Key Changes:
- Added three alerting rule templates (transform health, new group detection, missing usage data)
- Updated documentation to describe alerting capabilities and configuration
- Added validation exclusion for SVR00002
Reviewed changes
Copilot reviewed 29 out of 33 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/chargeback/kibana/alerting_rule_template/chargeback-transform-health.json | Adds transform health monitoring alert template |
| packages/chargeback/kibana/alerting_rule_template/chargeback-new-group-detected.json | Adds alert for detecting new chargeback groups |
| packages/chargeback/kibana/alerting_rule_template/chargeback-deployment-missing-usage-data.json | Adds alert for deployments missing usage data |
| packages/chargeback/docs/README.md | Documents new alerting features and configuration |
| packages/chargeback/changelog.yml | Records version 0.2.8 changes |
| packages/chargeback/validation.yml | Adds validation check exclusion |
| packages/chargeback/manifest.yml | Updates package version to 0.2.8 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "conf_query_weight": 20, | ||
| "conf_storage_weight": 40, | ||
| "conf_start_date": "2024-01-01T00:00:00.000Z", | ||
| "conf_end_date": "2024-12-31T23:tie" |
There was a problem hiding this comment.
Corrected spelling of 'tie' to '59:59.999Z' to complete the timestamp format.
Suggested change
| "conf_end_date": "2024-12-31T23:tie" | |
| "conf_end_date": "2024-12-31T23:59:59.999Z" |
| "conf_query_weight": 20, | ||
| "conf_storage_weight": 40, | ||
| "conf_start_date": "2024-01-01T00:00:00.000Z", | ||
| "conf_end_date": "2024-12-31T23:tie" |
There was a problem hiding this comment.
Corrected spelling of 'tie' to '59:59.999Z' to complete the timestamp format.
Suggested change
| "conf_end_date": "2024-12-31T23:tie" | |
| "conf_end_date": "2024-12-31T23:59:59.999Z" |
| - set: | ||
| field: cost_type | ||
| value: 'snapshots' | ||
| if: ctx.sku =~ /^(aws|gcp|azure).snapshot-storage&/ |
There was a problem hiding this comment.
Regular expression ends with '&' instead of '.*' - this pattern will not match snapshot storage SKUs correctly. Should be /^(aws|gcp|azure).snapshot-storage.*/
Suggested change
| if: ctx.sku =~ /^(aws|gcp|azure).snapshot-storage&/ | |
| if: ctx.sku =~ /^(aws|gcp|azure).snapshot-storage.*/ |
💚 Build Succeeded
|
Contributor
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots