crowdstrike: remove all statically set constant keyword fields in fdr at beginning of ingest #16240
+24
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efd6
added
Integration:crowdstrike
efd6
force-pushed
the
s6698-crowdstrike
branch
2 times, most recently
from
6d96b8b to
54d5517
Compare
… at beginning of ingest In cases where an unrecoverable error occurs in the ingest pipeline, the previous code would skip removal of ecs.version, resulting in a mapping failure since beats sets this value to 8.0.0, which does not match the static value. So remove this value at the beginning of the ingest pipeline to avoid this. Also remove all other statically defined constant keyword field values in case they have been set. Also fix a rename processor failure that is uncovered by this change where a condition attempt to access the ctx.crowdstrike?.User?.Name field through a string ctx.crowdstrike?.User field, resulting in a painless dynamic getter error.
efd6
force-pushed
the
s6698-crowdstrike
branch
from
54d5517 to
dad2ec1
Compare
andrewkroh
reviewed
Dec 4, 2025
| target_field: user.name | ||
| ignore_missing: true | ||
| if: ctx.crowdstrike?.User?.Name != null && ctx.user?.name == null | ||
| if: '!(ctx.crowdstrike?.User instanceof String) && ctx.crowdstrike?.User?.Name != null && ctx.user?.name == null' |
Member
There was a problem hiding this comment.
Suggested change
| if: '!(ctx.crowdstrike?.User instanceof String) && ctx.crowdstrike?.User?.Name != null && ctx.user?.name == null' | |
| if: 'ctx.crowdstrike?.User instanceof Map && ctx.crowdstrike?.User?.Name != null && ctx.user?.name == null' |
If ctx.crowdstrike.User were an array or another type without a Name field, attempting to read .Name could fail.
efd6
force-pushed
the
s6698-crowdstrike
branch
from
1c0274f to
9dc5a16
Compare
💔 Build Failed
Failed CI StepsHistory
cc @efd6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots