-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[Controls Anywhere] Add titlesManager to ESQL control #234974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Controls Anywhere] Add titlesManager to ESQL control #234974
Conversation
|
|
||
| export interface ESQLControlState { | ||
| grow?: boolean; | ||
| width?: ControlWidthOptions; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noticed these were throwing type errors now that we've removed width management so I also removed them in this PR
src/platform/plugins/shared/controls/public/controls/esql_control/get_esql_control_factory.tsx
Show resolved
Hide resolved
Heenawter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for tackling this so quickly 👍
⏳ Build in-progress, with failures
Failed CI Steps
Test Failures
History
|
Summary
Warning
This work is being merged into a feature branch, not main!
Because of this, we only need a review from @elastic/kibana-presentation for now.
Type failures are expected because the feature branch is currently in an incomplete state, where the controls that have not yet been converted are dependent on things that no longer exist.
Adds a
titlesManagerto ES|QL controls. This allows the panel title to update on edit. Previously it required a page reload to correctly update.To test:
Labelof an ES|QL control and ensure it updates on saveLabeland ensure the panel title switches to the variable name on save