Skip to content

Conversation

@Zacqary
Copy link
Contributor

@Zacqary Zacqary commented Sep 12, 2025

Summary

Warning

This work is being merged into a feature branch, not main!
Because of this, we only need a review from @elastic/kibana-presentation for now.

Type failures are expected because the feature branch is currently in an incomplete state, where the controls that have not yet been converted are dependent on things that no longer exist.

Adds a titlesManager to ES|QL controls. This allows the panel title to update on edit. Previously it required a page reload to correctly update.

To test:

  • Change the optional Label of an ES|QL control and ensure it updates on save
  • Remove the optional Label and ensure the panel title switches to the variable name on save

@Zacqary Zacqary added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// Project:Controls labels Sep 12, 2025
@Zacqary Zacqary requested review from a team as code owners September 12, 2025 21:24

export interface ESQLControlState {
grow?: boolean;
width?: ControlWidthOptions;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed these were throwing type errors now that we've removed width management so I also removed them in this PR

Copy link
Contributor

@Heenawter Heenawter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for tackling this so quickly 👍

@elasticmachine
Copy link
Contributor

elasticmachine commented Sep 12, 2025

⏳ Build in-progress, with failures

Failed CI Steps

Test Failures

  • [job] [logs] Scout: [ security / security_solution ] plugin / serverless-security - Expandable flyout state sync - should test flyout url sync
  • [job] [logs] Scout: [ observability / slo ] plugin / stateful - Annotations List - check that annotation is displayed
  • [job] [logs] Scout: [ observability / slo ] plugin / stateful - Annotations List - delete annotation
  • [job] [logs] Scout: [ observability / slo ] plugin / stateful - Annotations List - Go to slos
  • [job] [logs] Scout: [ observability / slo ] plugin / stateful - Annotations List - update annotation
  • [job] [logs] Scout: [ observability / slo ] plugin / stateful - Annotations List - validate annotation list
  • [job] [logs] Scout: [ security / security_solution ] plugin / stateful - Expandable flyout state sync - should test flyout url sync
  • [job] [logs] Scout: [ observability / slo ] plugin / stateful - SLOs Overview - Go to slos overview and validate data retention tab

History

@Zacqary Zacqary merged commit 26f6718 into elastic:controlsAnywhere Sep 15, 2025
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Project:Controls Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t//

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants