Skip to content

[Controls Anywhere] Add titlesManager to ESQL control #234974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 15, 2025
Merged

[Controls Anywhere] Add titlesManager to ESQL control #234974

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ad007bb
[Controls Anywhere] Add titlesManager to ESQL control
Zacqary Sep 12, 2025
b6d2cc9
Add titles manager to onReset
Zacqary Sep 12, 2025
782b734
[CI] Auto-commit changed files from 'node scripts/eslint_all_files --…
kibanamachine Sep 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/platform/packages/shared/kbn-esql-types/src/variables_types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,6 @@ export interface PublishesESQLVariable {
export type ControlWidthOptions = 'small' | 'medium' | 'large';

export interface ESQLControlState {
grow?: boolean;
width?: ControlWidthOptions;
Copy link
Contributor Author

@Zacqary Zacqary Sep 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed these were throwing type errors now that we've removed width management so I also removed them in this PR

title: string;
selectedOptions: string[];
variableName: string;
Expand Down
12 changes: 11 additions & 1 deletion ...latform/plugins/shared/controls/public/controls/esql_control/get_esql_control_factory.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,11 @@ import type { ESQLControlState } from '@kbn/esql-types';
import { apiPublishesESQLVariables } from '@kbn/esql-types';
import { i18n } from '@kbn/i18n';
import { initializeUnsavedChanges } from '@kbn/presentation-containers';
import { initializeStateManager } from '@kbn/presentation-publishing';
import {
initializeStateManager,
initializeTitleManager,
titleComparators,
} from '@kbn/presentation-publishing';
import type { OptionsListSelection } from '@kbn/controls-schemas';

import { uiActionsService } from '../../services/kibana_services';
Expand All @@ -38,6 +42,7 @@ export const getESQLControlFactory = (): EmbeddableFactory<ESQLControlState, ESQ
buildEmbeddable: async ({ initialState, finalizeApi, uuid, parentApi }) => {
const state = initialState.rawState;
const defaultControlManager = initializeDefaultControlManager();
const titlesManager = initializeTitleManager(state);

// TODO Rename this; this is actually the state manager for all non-default control state params, "selections" is a confusing name
const selections = initializeESQLControlSelections(
Expand All @@ -63,14 +68,17 @@ export const getESQLControlFactory = (): EmbeddableFactory<ESQLControlState, ESQ
getComparators: () => {
return {
...selectionComparators,
...titleComparators,
};
},
onReset: (lastSaved) => {
selections.reinitializeState(lastSaved?.rawState);
titlesManager.reinitializeState(lastSaved?.rawState);
},
});

const api = finalizeApi({
...titlesManager.api,
...unsavedChangesApi,
...defaultControlManager.api,
...selections.api,
Expand All @@ -79,13 +87,15 @@ export const getESQLControlFactory = (): EmbeddableFactory<ESQLControlState, ESQ
getTypeDisplayName: () => displayName,
onEdit: async () => {
const nextState = {
...titlesManager.getLatestState(),
...selections.getLatestState(),
};
const variablesInParent = apiPublishesESQLVariables(api.parentApi)
? api.parentApi.esqlVariables$.value
: [];
const onSaveControl = async (updatedState: ESQLControlState) => {
selections.reinitializeState(updatedState);
titlesManager.reinitializeState(updatedState);
};
try {
await uiActionsService.getTrigger('ESQL_CONTROL_TRIGGER').exec({
Expand Down