-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] Exclude events log from EA diagnostic collection in modal #190469
base: main
Are you sure you want to change the base?
[Fleet] Exclude events log from EA diagnostic collection in modal #190469
Conversation
x-pack/plugins/fleet/common/openapi/paths/agents@bulk_request_diagnostics.yaml
Outdated
Show resolved
Hide resolved
x-pack/plugins/fleet/common/openapi/paths/agents@{agent_id}@request_diagnostics.yaml
Outdated
Show resolved
Hide resolved
...blic/applications/fleet/sections/agents/components/agent_request_diagnostics_modal/index.tsx
Outdated
Show resolved
Hide resolved
17ace30
to
46431f2
Compare
Tested locally with 8.15 and 8.11 to ensure the flag is not preventing the diagnostic collection on older Elastic Agent versions. We might need to put this on hold until Elastic Agent considers this flag in the protocol and repeat the tests as afaik this requires a protocol change. |
…quest_diagnostics.yaml
…/components/agent_request_diagnostics_modal/index.tsx
3b680d2
to
f364626
Compare
@@ -23,7 +23,8 @@ import { | |||
export async function requestDiagnostics( | |||
esClient: ElasticsearchClient, | |||
agentId: string, | |||
additionalMetrics?: RequestDiagnosticsAdditionalMetrics[] | |||
additionalMetrics?: RequestDiagnosticsAdditionalMetrics[], | |||
excludeEventsLog?: boolean, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not 100% sure
@@ -36,7 +36,7 @@ describe('request diagnostics handler', () => { | |||
let mockRequest: KibanaRequest< | |||
{ agentId: string }, | |||
undefined, | |||
{ additional_metrics: RequestDiagnosticsAdditionalMetrics[] }, | |||
{ additional_metrics: RequestDiagnosticsAdditionalMetrics[]; exclude_events_log?: boolean }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not 100% sure
Pinging @elastic/fleet (Team:Fleet) |
Got the following error when trying the API You will have to update the request schema for the POST request diagnostic and bulk operation too here |
<EuiCheckbox | ||
id="includeEventsLogCheckbox" | ||
data-test-subj="includeEventsLogCheckbox" | ||
label="Include Events Logs (might contain sensible information)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will be nice to have translated value with i18n.translate
for the label
💚 CLA has been signed |
f6c0316
to
196c758
Compare
💔 Build FailedFailed CI StepsTest Failures
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
Summary
In 8.15 we've reintroduced the logging of raw events when in debug log via elastic/beats#38767.
Given the Elastic Agent is able to read the flag from the action (https://github.com/elastic/elastic-agent/blob/44528c49507c18e71a4cfd2a6ba4f0904bd32009/internal/pkg/fleetapi/action.go#L483), I'm attempting to draft a PR.
Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
exclude_event_logs
?For maintainers