Skip to content

Conversation

@alexreal1314
Copy link
Contributor

@alexreal1314 alexreal1314 commented May 22, 2025

Summary

This PR backports changes related to Qualys VMDR added integration support that were merged to version 9.1.0.

PRs backported:

Identify risks

Thorough sanity check need to be made before merging since a lot of conflicts were fixed manually.

update flyout overview tab to support multiple cves, published date move to be above alerts section
…alues

update insights tab vulnerabilities column names

fix redirect from insights tab to vulnerabilties findings page
update flyout overview tab to support multiple cves, published date move to be above alerts section
…alues

update insights tab vulnerabilities column names

fix redirect from insights tab to vulnerabilties findings page
… for multil values fields

fix severity utility function types
@kibanamachine kibanamachine requested a review from a team May 22, 2025 18:14
@alexreal1314 alexreal1314 changed the base branch from main to 8.19 May 22, 2025 18:15
@alexreal1314 alexreal1314 added Team:Cloud Security Cloud Security team related ci:cloud-deploy Create or update a Cloud deployment Feature:Cloud-Security Cloud Security related features labels May 22, 2025
@alexreal1314 alexreal1314 force-pushed the backport-221247-backport-qualys-related-changes branch from a5801f9 to f4250c3 Compare May 22, 2025 21:20
@kibanamachine
Copy link
Contributor

Cloud deployment initiated, see credentials at: https://buildkite.com/elastic/kibana-deploy-cloud-from-pr/builds/187

@alexreal1314 alexreal1314 marked this pull request as ready for review May 23, 2025 10:04
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

@alexreal1314 alexreal1314 added backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes labels May 23, 2025
@kc13greiner kc13greiner requested review from a team and removed request for a team May 23, 2025 12:58
@kc13greiner
Copy link
Contributor

Kibana Security was tagged for review (Im not sure why KB machine tagged us 🤷‍♂️ ) and the PR LGTM, but I figured this would be best for Cloud Security to review

@maxcold
Copy link
Contributor

maxcold commented May 23, 2025

Tested with Qualys data, found one issue which might be related to backporting: the filtering of the page by CVE id sometimes (not for all CVEs and I couldn't find a pattern) crashes the page. Refreshing the page with the same filter then works fine. I will investigate if Alex won't be available

Screenshot 2025-05-23 at 14 50 37

@alexreal1314 alexreal1314 force-pushed the backport-221247-backport-qualys-related-changes branch from f3def2a to 62e273c Compare May 24, 2025 07:20
@alexreal1314 alexreal1314 force-pushed the backport-221247-backport-qualys-related-changes branch from 9bdc1ec to fae2ccd Compare May 25, 2025 14:43
Copy link
Contributor

@maxcold maxcold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes introduced in the backport are tested, the backport should be ready to be merged


const createVulnerabilityRuleFn = (rowIndex: number) => {
const vulnerabilityFinding = getCspVulnerabilityFinding(rows[rowIndex].raw._source);
const vulnerabilityFinding = getCspVulnerabilityFinding(rows[rowIndex]?.raw._source);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the issue I brought up in the comments, now the backport should be ready to go

@maxcold maxcold requested review from a team and removed request for kibanamachine May 27, 2025 08:35
@elasticmachine
Copy link
Contributor

elasticmachine commented May 27, 2025

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
cloudSecurityPosture 696 707 +11
securitySolution 7283 7292 +9
total +20

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/cloud-security-posture 93 109 +16
@kbn/cloud-security-posture-common 120 124 +4
total +20

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cloudSecurityPosture 492.7KB 504.1KB +11.4KB
securitySolution 9.2MB 9.2MB +4.7KB
total +16.1KB
Unknown metric groups

API count

id before after diff
@kbn/cloud-security-posture 93 110 +17
@kbn/cloud-security-posture-common 122 126 +4
total +21

History

@maxcold maxcold merged commit de8e153 into 8.19 May 27, 2025
8 checks passed
@maxcold maxcold deleted the backport-221247-backport-qualys-related-changes branch May 27, 2025 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting ci:cloud-deploy Create or update a Cloud deployment Feature:Cloud-Security Cloud Security related features release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Security Cloud Security team related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Cloud Security] backport Qualys related changes to 8.19

6 participants