Skip to content

[Agent Builder] Rename feature to "agent builder" #234304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 13, 2025
Merged

[Agent Builder] Rename feature to "agent builder" #234304

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
908ad07
[onechat] rename feature to "agent builder"
pgayvallet Sep 8, 2025
32f9bcf
rename feature name in tests
pgayvallet Sep 8, 2025
005d004
Merge remote-tracking branch 'upstream/main' into kbn-xxx-agent-build…
pgayvallet Sep 10, 2025
d0c36d8
move agent builder to solution feature section
pgayvallet Sep 10, 2025
2de8a46
use correct category for ES too
pgayvallet Sep 10, 2025
b96add6
adapt test cases
pgayvallet Sep 10, 2025
4afcb3d
fix test againain
pgayvallet Sep 10, 2025
cebd7e2
Merge remote-tracking branch 'upstream/main' into kbn-xxx-agent-build…
pgayvallet Sep 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions config/serverless.es.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@ xpack.fleet.internal.registry.excludePackages: [

## Fine-tune the search solution feature privileges. Also, refer to `serverless.yml` for the project-agnostic overrides.
xpack.features.overrides:
### Agent Builder feature is moved from Analytics category to the Search one.
agentBuilder.category: 'enterpriseSearch'
### Dashboards feature is moved from Analytics category to the Search one.
dashboard_v2.category: "enterpriseSearch"
### Dev Tools feature is moved from Analytics category to the Search one.
Expand Down
2 changes: 2 additions & 0 deletions config/serverless.oblt.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ xpack.features.overrides:
### Discover feature should be moved from Analytics category to the Observability one and its privileges are
### fine-tuned to grant access to Observability app.
discover_v2.category: 'observability'
### Agent Builder should be moved from Analytics category to the Observability one.
agentBuilder.category: 'observability'
Copy link
Member

@azasypkin azasypkin Sep 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we intentionally keep Agent Builder under Analytics in the Chat project type and as the only item in that category for Search project type?

image

Also, not related to this PR, but Workchat Framework doesn't look right

Screenshot 2025-09-10 at 09 02 17

Copy link
Contributor Author

@pgayvallet pgayvallet Sep 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the chat project type yes (for now).
For search definitely not, thank you I'll fix that.


# Customize empty page state for analytics apps
no_data_page.analyticsNoDataPageFlavor: 'serverless_observability'
Expand Down
6 changes: 5 additions & 1 deletion config/serverless.security.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,14 @@ xpack.features.overrides:
visualize_v2.hidden: true
maps.hidden: true
maps_v2.hidden: true
### agent builder feature is moved from Analytics category to the Security one the bottom
agentBuilder:
category: "security"
order: 1101
### Machine Learning feature is moved from Analytics category to the Security one as the last item.
ml:
category: "security"
order: 1101
order: 1102
### Security's feature privileges are fine-tuned to grant access to Discover, Dashboard, Maps, and Visualize apps.
siemV3:
privileges:
Expand Down
2 changes: 0 additions & 2 deletions config/serverless.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@ xpack.fleet.internal.registry.spec.max: '3.4'

## Fine-tune the feature privileges.
xpack.features.overrides:
onechat:
hidden: true
dashboard:
privileges:
### Dashboard's `All` feature privilege should implicitly grant `All` access to Maps and Visualize features.
Expand Down
4 changes: 2 additions & 2 deletions x-pack/platform/plugins/shared/onechat/common/features.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
* 2.0.
*/

export const ONECHAT_FEATURE_ID = 'onechat';
export const ONECHAT_FEATURE_NAME = 'onechat';
export const ONECHAT_FEATURE_ID = 'agentBuilder';
export const ONECHAT_FEATURE_NAME = 'Agent Builder';
export const ONECHAT_APP_ID = 'onechat';
export const ONECHAT_PATH = '/app/chat';
export const ONECHAT_TITLE = 'Chat';
Expand Down
4 changes: 2 additions & 2 deletions x-pack/platform/test/api_integration/apis/features/features/features.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@ export default function ({ getService }: FtrProviderContext) {
'dataQuality',
'dev_tools',
'actions',
'agentBuilder',
'enterpriseSearch',
'enterpriseSearchApplications',
'enterpriseSearchAnalytics',
Expand All @@ -113,7 +114,6 @@ export default function ({ getService }: FtrProviderContext) {
'monitoring',
'observabilityAIAssistant',
'observabilityCasesV3',
'onechat',
'savedObjectsManagement',
'savedQueryManagement',
'savedObjectsTagging',
Expand Down Expand Up @@ -161,6 +161,7 @@ export default function ({ getService }: FtrProviderContext) {
'dataQuality',
'dev_tools',
'actions',
'agentBuilder',
'enterpriseSearch',
'enterpriseSearchApplications',
'enterpriseSearchAnalytics',
Expand All @@ -173,7 +174,6 @@ export default function ({ getService }: FtrProviderContext) {
'monitoring',
'observabilityAIAssistant',
'observabilityCasesV3',
'onechat',
'savedObjectsManagement',
'savedQueryManagement',
'savedObjectsTagging',
Expand Down
2 changes: 1 addition & 1 deletion x-pack/platform/test/api_integration/apis/security/privileges.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ export default function ({ getService }: FtrProviderContext) {
'cases_assign',
],
observabilityAIAssistant: ['all', 'read', 'minimal_all', 'minimal_read'],
onechat: ['all', 'read', 'minimal_all', 'minimal_read'],
agentBuilder: ['all', 'read', 'minimal_all', 'minimal_read'],
slo: ['all', 'read', 'minimal_all', 'minimal_read'],
searchPlayground: ['all', 'read', 'minimal_all', 'minimal_read'],
searchSynonyms: ['all', 'read', 'minimal_all', 'minimal_read'],
Expand Down
4 changes: 2 additions & 2 deletions x-pack/platform/test/api_integration_basic/apis/security/privileges.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ export default function ({ getService }: FtrProviderContext) {
observabilityCasesV2: ['all', 'read', 'minimal_all', 'minimal_read'],
observabilityCasesV3: ['all', 'read', 'minimal_all', 'minimal_read'],
observabilityAIAssistant: ['all', 'read', 'minimal_all', 'minimal_read'],
onechat: ['all', 'read', 'minimal_all', 'minimal_read'],
agentBuilder: ['all', 'read', 'minimal_all', 'minimal_read'],
slo: ['all', 'read', 'minimal_all', 'minimal_read'],
canvas: ['all', 'read', 'minimal_all', 'minimal_read'],
infrastructure: ['all', 'read', 'minimal_all', 'minimal_read'],
Expand Down Expand Up @@ -193,7 +193,7 @@ export default function ({ getService }: FtrProviderContext) {
'cases_assign',
],
observabilityAIAssistant: ['all', 'read', 'minimal_all', 'minimal_read'],
onechat: ['all', 'read', 'minimal_all', 'minimal_read'],
agentBuilder: ['all', 'read', 'minimal_all', 'minimal_read'],
slo: ['all', 'read', 'minimal_all', 'minimal_read'],
searchPlayground: ['all', 'read', 'minimal_all', 'minimal_read'],
searchSynonyms: ['all', 'read', 'minimal_all', 'minimal_read'],
Expand Down
2 changes: 1 addition & 1 deletion x-pack/platform/test/spaces_api_integration/spaces_only/telemetry/telemetry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ export default function ({ getService }: FtrProviderContext) {
observabilityCases: 0,
observabilityCasesV2: 0,
observabilityCasesV3: 0,
onechat: 0,
agentBuilder: 0,
uptime: 0,
slo: 0,
infrastructure: 0,
Expand Down
3 changes: 2 additions & 1 deletion ...s/observability/test/serverless/functional/test_suites/logs_essentials_only/privileges.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,12 +51,13 @@ export default function ({ getPageObject, getPageObjects, getService }: FtrProvi
return await privilege.getVisibleText();
})
);
expect(privileges.length).to.be(4);
expect(privileges.length).to.be(5);
expect(text).to.eql([
'Discover\nAll\nRead\nNone',
'Dashboard\nAll\nRead\nNone',
'Streams\nAll\nRead\nNone',
'Logs\nAll\nRead\nNone',
'Agent Builder\nAll\nRead\nNone',
]);
});

Expand Down
3 changes: 2 additions & 1 deletion x-pack/solutions/observability/test/serverless/functional/test_suites/privileges.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,14 +51,15 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
return await privilege.getVisibleText();
})
);
expect(privileges.length).to.be(11);
expect(privileges.length).to.be(12);
expect(text).to.eql([
'Discover\nAll\nRead\nNone',
'Dashboard\nAll\nRead\nNone',
'Streams\nAll\nRead\nNone',
'Logs\nAll\nRead\nNone',
'Infrastructure\nAll\nRead\nNone',
'Applications\nAll\nRead\nNone',
'Agent Builder\nAll\nRead\nNone',
'Synthetics\nAll\nRead\nNone',
'Cases\nAll\nRead\nNone',
'Machine Learning\nAll\nRead\nNone',
Expand Down