Quick tweaks for the feedback snippet #234499
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
🤖 Jobs for this PR can be triggered through checkboxes. 🚧
ℹ️ To trigger the CI, please tick the checkbox below 👇
|
Contributor
Author
|
Hey @angeles-mb, thanks for a great work on fb snippet 🙏 |
This was referenced Sep 12, 2025
angeles-mb
added a commit
that referenced
this pull request
Sep 18, 2025
Closes #234863 ## Summary - Added feedback snippet to our Storybook with custom controls to test props - Integrated some UI tweaks suggested by @ek-so #234499 - A top divider for the feedback button - Smaller buttons ## Testing Tested divider on scrollable submenus: <img width="743" height="1051" alt="Screenshot 2025-09-16 at 12 05 47" src="https://github.com/user-attachments/assets/75589637-9adc-4bfb-99a1-ccccf50b00e9" /> Tested divider on non-scrollable submenus: <img width="743" height="1043" alt="Screenshot 2025-09-16 at 13 06 05" src="https://github.com/user-attachments/assets/69ba7b47-b3e0-4624-aa1a-0d1ea7f32e6b" /> Storybook looks: <img width="895" height="1019" alt="Screenshot 2025-09-16 at 12 07 13" src="https://github.com/user-attachments/assets/dba37ae4-9055-4b6b-8494-870c35f81890" /> --------- Co-authored-by: kibanamachine <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Sep 24, 2025
Closes elastic#234863 ## Summary - Added feedback snippet to our Storybook with custom controls to test props - Integrated some UI tweaks suggested by @ek-so elastic#234499 - A top divider for the feedback button - Smaller buttons ## Testing Tested divider on scrollable submenus: <img width="743" height="1051" alt="Screenshot 2025-09-16 at 12 05 47" src="https://github.com/user-attachments/assets/75589637-9adc-4bfb-99a1-ccccf50b00e9" /> Tested divider on non-scrollable submenus: <img width="743" height="1043" alt="Screenshot 2025-09-16 at 13 06 05" src="https://github.com/user-attachments/assets/69ba7b47-b3e0-4624-aa1a-0d1ea7f32e6b" /> Storybook looks: <img width="895" height="1019" alt="Screenshot 2025-09-16 at 12 07 13" src="https://github.com/user-attachments/assets/dba37ae4-9055-4b6b-8494-870c35f81890" /> --------- Co-authored-by: kibanamachine <[email protected]>
niros1
pushed a commit
that referenced
this pull request
Sep 30, 2025
Closes #234863 ## Summary - Added feedback snippet to our Storybook with custom controls to test props - Integrated some UI tweaks suggested by @ek-so #234499 - A top divider for the feedback button - Smaller buttons ## Testing Tested divider on scrollable submenus: <img width="743" height="1051" alt="Screenshot 2025-09-16 at 12 05 47" src="https://github.com/user-attachments/assets/75589637-9adc-4bfb-99a1-ccccf50b00e9" /> Tested divider on non-scrollable submenus: <img width="743" height="1043" alt="Screenshot 2025-09-16 at 13 06 05" src="https://github.com/user-attachments/assets/69ba7b47-b3e0-4624-aa1a-0d1ea7f32e6b" /> Storybook looks: <img width="895" height="1019" alt="Screenshot 2025-09-16 at 12 07 13" src="https://github.com/user-attachments/assets/dba37ae4-9055-4b6b-8494-870c35f81890" /> --------- Co-authored-by: kibanamachine <[email protected]>
rylnd
pushed a commit
to rylnd/kibana
that referenced
this pull request
Oct 17, 2025
Closes elastic#234863 ## Summary - Added feedback snippet to our Storybook with custom controls to test props - Integrated some UI tweaks suggested by @ek-so elastic#234499 - A top divider for the feedback button - Smaller buttons ## Testing Tested divider on scrollable submenus: <img width="743" height="1051" alt="Screenshot 2025-09-16 at 12 05 47" src="https://github.com/user-attachments/assets/75589637-9adc-4bfb-99a1-ccccf50b00e9" /> Tested divider on non-scrollable submenus: <img width="743" height="1043" alt="Screenshot 2025-09-16 at 13 06 05" src="https://github.com/user-attachments/assets/69ba7b47-b3e0-4624-aa1a-0d1ea7f32e6b" /> Storybook looks: <img width="895" height="1019" alt="Screenshot 2025-09-16 at 12 07 13" src="https://github.com/user-attachments/assets/dba37ae4-9055-4b6b-8494-870c35f81890" /> --------- Co-authored-by: kibanamachine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some tweaks proposed for #234187