[8.19] [Security Solution] Implement Prebuilt Rules Customization test plan (#232776) #234501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lastic#232776) **Resolves: elastic#202068 ## Summary This PR implements [prebuilt rules customization test plan](https://github.com/elastic/kibana/blob/main/x-pack/solutions/security/plugins/security_solution/docs/testing/test_plans/detection_response/prebuilt_rules/prebuilt_rule_customization.md). ## Details The major part of the [prebuilt rules customization test plan](https://github.com/elastic/kibana/blob/main/x-pack/solutions/security/plugins/security_solution/docs/testing/test_plans/detection_response/prebuilt_rules/prebuilt_rule_customization.md) had been implemented already so this PR adds missing test scenario implementations and refactors the existing tests. In particular the following has been done - Prebuilt rules reverting customization test plan has been extracted - Existing prebuilt rule customization tests have been refactored to improve naming and remove duplicates - Test scenario implementations for missing base version have been added - Test scenario implementations for insufficient license have been added - Per field customization integration tests now also verify the customization can be reverted by saving original field value Extended test coverage is crucial for making sure changes suggested in elastic#230856 don't bring in new issues. ## Flaky test runner - [Prebuilt rule customization integration tests](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/9251) (200 runs) - [Prebuilt rule customization e2e tests](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/9254) (100 runs) (cherry picked from commit 57d96cf) # Conflicts: # x-pack/solutions/security/test/security_solution_api_integration/test_suites/detections_response/rules_management/prebuilt_rules/customization_disabled/customization/calculate_is_customized.ts # x-pack/solutions/security/test/security_solution_api_integration/test_suites/detections_response/rules_management/prebuilt_rules/customization_enabled/customization/calculate_is_customized.ts # x-pack/solutions/security/test/security_solution_api_integration/test_suites/detections_response/rules_management/prebuilt_rules/customization_enabled/customization/customize_prebuilt_rules.ts
Contributor
💚 Build Succeeded
Metrics [docs]
History
|
dplumlee
approved these changes
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.19:Questions ?
Please refer to the Backport tool documentation