[9.1] [kbn-eslint-plugin-eslint] add scout_no_describe_configure rule (#234390) #234519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tic#234390) ## Summary Adding new rule to prevent playwright runner configuration overrides in spec files. It is important to keep runner functionality unified across all the Scout tests and having custom logic may lead to unexpected CI behavior or wrong test results ingestion. We already have unified functionality in place: - retrying failure is handled on CI script level - parallel test execution is limited to test spec level (we don't allow concurrent run of tests within the same file) - explicit timeouts for test execution is not recommended, but can be accepted for individual cases Adding smth like: ``` spaceTest.describe('Discover app - errors', { tag: tags.ESS_ONLY }, () => { spaceTest.describe.configure({ retries: 2, timeout: 120000, }); ``` will be blocked by pre-commit hook: ``` *[scout/scout_no_describe_configure][~/github/kibana]$ gc "add configure" ERROR /Users/dmle/github/kibana/x-pack/platform/plugins/private/discover_enhanced/test/scout/ui/parallel_tests/error_handling.spec.ts 12:3 error Using describe.configure is not allowed in Scout tests @kbn/eslint/scout_no_describe_configure ``` (cherry picked from commit 1d540a7)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
💚 Build Succeeded
Metrics [docs]
cc @dmlemeshko |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto9.1:Questions ?
Please refer to the Backport tool documentation