[9.0] [Security Solution] Fix StepDefineRule Jest tests (#233762) #234536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Resolves: elastic#199648 **Resolves: elastic#199700 ## Summary This PR moves StepDefineRule Jest unit tests to Jest integration tests category. This helps to unskip related integration tests since those take more time to execute and Jest integration tests have higher timeouts. ## Details StepDefineRule component is large enough with multiple dependencies to be treated as an isolated piece of functionality for integration testing. Running these tests as Jest unit tests wasn't the correct approach as such tests take more time to execute and may fail due to small unit tests execution time threshold. However, Jest integration tests group provides enough large timeouts for related integration tests to finish. Based on the experience with Jest integration tests for [Prebuilt Rules Customization](https://github.com/elastic/kibana/tree/main/x-pack/solutions/security/plugins/security_solution/public/detection_engine/rule_management_ui/pages/rule_management/__integration_tests__/rules_upgrad) in e this approach is the right one for testing large UI components. (cherry picked from commit 27d516a) # Conflicts: # x-pack/solutions/security/plugins/security_solution/public/detection_engine/rule_creation_ui/components/step_define_rule/__integration_tests__/step_define_rule.test.tsx
Contributor
|
@elasticmachine merge upstream |
banderror
approved these changes
Sep 11, 2025
Contributor
💚 Build Succeeded
Metrics [docs]
History
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto9.0:Questions ?
Please refer to the Backport tool documentation