[New navigation] Use custom offset in EuiTooltip #234553
Conversation
This caused a failure on main, likely due to a PR being merged around the same time as elastic#229868, which removes the usage of the translation.
paulinashakirova
added
release_note:skip
paulinashakirova
changed the title
|
@elasticmachine merge upstream |
| export const TOP_BAR_HEIGHT = 48; | ||
| export const TOP_BAR_POPOVER_GAP = 8; | ||
| export const BOTTOM_POPOVER_GAP = 17; | ||
| export const POPOVER_OFFSET = 5; |
There was a problem hiding this comment.
@paulinashakirova Why is POPOVER_OFFSET changed here to TOOLTIP_OFFSET?
There was a problem hiding this comment.
They got merged locally at some point, but I’ve split them out now.
Nice catch — appreciate you calling it out 👍
| export const TOP_BAR_POPOVER_GAP = 8; | ||
| export const BOTTOM_POPOVER_GAP = 17; | ||
| export const POPOVER_OFFSET = 5; | ||
| export const TOOLTIP_OFFSET = 4; |
There was a problem hiding this comment.
@ek-so what do you think about this value? Should we have 2 different ones for collapsed and expanded mode?
There was a problem hiding this comment.
@weronikaolejniczak thanks for tagging! I took a look already, I think it's fine
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
weronikaolejniczak
left a comment
weronikaolejniczak
left a comment
There was a problem hiding this comment.
LGTM, Kate approves so we're good to go 🚀 thanks, @paulinashakirova!
## Summary Implementing custom `EuiToolTip` following new functionality to be able to customize tooltip distance ([eui](https://github.com/elastic/eui/pull/8988/files)).
## Summary Implementing custom `EuiToolTip` following new functionality to be able to customize tooltip distance ([eui](https://github.com/elastic/eui/pull/8988/files)).
6 participants
Summary
Implementing custom
EuiToolTipfollowing new functionality to be able to customize tooltip distance (eui).4px offset looks like this
Compressed mode
Expanded mode