-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[Discover] Adapt logs flyout to use the new content framework UI #234650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Discover] Adapt logs flyout to use the new content framework UI #234650
Conversation
…-new-content-framework-ui
…-new-content-framework-ui
|
/oblt-deploy |
…ts/content_framework/section/section.tsx Co-authored-by: Cauê Marcondes <[email protected]>
akowalska622
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Data Discovery changes LGTM
|
Adding to the discussion - the separated "Streams" section was now created due to technical limitations - the lack of ability of placing "field = stream" + value in the "About" section. I would definitely recommend against separating it into a new section, but I know the team has investigated our options in the context of the new UI components and it was a challenge. I will work with @iblancof this week to review the designs and we'll get back to you. We'll move around the sections to reflect the "old" logic. |
|
A follow up question we had about the sections in the logs flyout @gbamparop We have divided the flyout in "Service and Infrastructure" / "Cloud" / "Other". With the new components, we'd need to add "Streams". What we proposed in our refreshed designs is to redesign or limit the divisions of content within the flyout. The new designs offer an "About" section that could handle all of them. This would make the information more compact, and in cases where the log document does not render all the fields, it would definitely help with the overall presentation. Was there any particular reason to divide the metadata into 3 short sections? Are there any reasons we cannot merge the sections? This would be our general recommendation (draft - some content is pending product definition), I've moved the "Content breakdown" up (missing "Streams" for now):
|
cauemarcondes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…-new-content-framework-ui
Thanks!
They were added to give a brief overview of the different parts, however, I think it’s important to have the same UX in these tabs and since resource fields are not unique to logs, we could follow the other approach. There was some discussion in #171923 and a card sorting exercise organised by @isaclfreire #171923 (comment). |
|
Hey @gbamparop, after your feedback, I aligned with @kkurstak that we’ll place the “Content Breakdown” section first and include the highlights within it, so they’ll also be collapsed. fa45cfd Regarding the Streams link we're still waiting for feedback from the Streams folks. |
|
Hey @gbamparop @iblancof - Thank you so much for all info and feedback. Happy to hear the team is open to change the structure and follow our designs! I will review in detail the past issue where the current structure was decided and reach out to the team to share the why of our change - I'd like to share it so we eventually have time to receive feedback. Once again, thanks @gbamparop! |
…-new-content-framework-ui
|
Just confirmed with @LucaWintergerst that we’re good to go with having the stream link in a separate section, as we may have many more other functions in the future that definitely won’t relate directly to a single field anymore. |
…-new-content-framework-ui
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Public APIs missing exports
Page load bundle
History
cc @iblancof |
…stic#234650) ## Summary Closes elastic#233743 This PR is a continuation of [another one](elastic#233661), where the UI for the trace docs overview is updated, aiming to achieve visual consistency across Discover flyouts. In the logs case, the basic information sections have been grouped at the top, and the other sections have been adapted to align with the Content Framework as much as possible, without making major changes. **Flyout** |Before|After| |-|-| |<img width="325" height="716" alt="Screenshot 2025-09-10 at 16 58 17" src="https://github.com/user-attachments/assets/b9bd6ae0-3164-45b1-bba6-33ebf2ada596" />|<img width="482" height="839" alt="Screenshot 2025-09-10 at 17 08 22" src="https://github.com/user-attachments/assets/2cdb76e8-6c17-498f-845d-e1c3380213a4" />| **Interactions** |Before|After| |-|-| ||| ### How to test - Make sure you're in an Observability space - Go to discover and check for logs - Open doc flyout To get logs with degraded fields filter by `_ignored:*`. --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Cauê Marcondes <[email protected]>
…4650) ## Summary Closes #233743 This PR is a continuation of [another one](#233661), where the UI for the trace docs overview is updated, aiming to achieve visual consistency across Discover flyouts. In the logs case, the basic information sections have been grouped at the top, and the other sections have been adapted to align with the Content Framework as much as possible, without making major changes. **Flyout** |Before|After| |-|-| |<img width="325" height="716" alt="Screenshot 2025-09-10 at 16 58 17" src="https://github.com/user-attachments/assets/b9bd6ae0-3164-45b1-bba6-33ebf2ada596" />|<img width="482" height="839" alt="Screenshot 2025-09-10 at 17 08 22" src="https://github.com/user-attachments/assets/2cdb76e8-6c17-498f-845d-e1c3380213a4" />| **Interactions** |Before|After| |-|-| ||| ### How to test - Make sure you're in an Observability space - Go to discover and check for logs - Open doc flyout To get logs with degraded fields filter by `_ignored:*`. --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Cauê Marcondes <[email protected]>
…stic#234650) ## Summary Closes elastic#233743 This PR is a continuation of [another one](elastic#233661), where the UI for the trace docs overview is updated, aiming to achieve visual consistency across Discover flyouts. In the logs case, the basic information sections have been grouped at the top, and the other sections have been adapted to align with the Content Framework as much as possible, without making major changes. **Flyout** |Before|After| |-|-| |<img width="325" height="716" alt="Screenshot 2025-09-10 at 16 58 17" src="https://github.com/user-attachments/assets/b9bd6ae0-3164-45b1-bba6-33ebf2ada596" />|<img width="482" height="839" alt="Screenshot 2025-09-10 at 17 08 22" src="https://github.com/user-attachments/assets/2cdb76e8-6c17-498f-845d-e1c3380213a4" />| **Interactions** |Before|After| |-|-| ||| ### How to test - Make sure you're in an Observability space - Go to discover and check for logs - Open doc flyout To get logs with degraded fields filter by `_ignored:*`. --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Cauê Marcondes <[email protected]>


Summary
Closes #233743
This PR is a continuation of another one, where the UI for the trace docs overview is updated, aiming to achieve visual consistency across Discover flyouts.
In the logs case, the basic information sections have been grouped at the top, and the other sections have been adapted to align with the Content Framework as much as possible, without making major changes.
Flyout
Interactions
How to test
To get logs with degraded fields filter by
_ignored:*.