[Security assistant] Fix System Prompt updates from Conversations tab #234812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephmilovic
added
release_note:fix
Team: SecuritySolution
Contributor
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest FailuresMetrics [docs]Async chunks
|
KDKHD
approved these changes
Sep 12, 2025
Contributor
|
Starting backport for target branches: 8.19, 9.1 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 12, 2025
…elastic#234812) (cherry picked from commit 540e69f)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 12, 2025
…elastic#234812) (cherry picked from commit 540e69f)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Sep 12, 2025
…ons tab (#234812) (#234926) # Backport This will backport the following commits from `main` to `8.19`: - [[Security assistant] Fix System Prompt updates from Conversations tab (#234812)](#234812) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Steph Milovic","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-09-12T14:23:10Z","message":"[Security assistant] Fix System Prompt updates from Conversations tab (#234812)","sha":"540e69f494bb36fd269f418d4dd03d29c13b8eb1","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team: SecuritySolution","Team:Security Generative AI","backport:version","v9.2.0","v8.19.5","v9.1.5"],"title":"[Security assistant] Fix System Prompt updates from Conversations tab","number":234812,"url":"https://github.com/elastic/kibana/pull/234812","mergeCommit":{"message":"[Security assistant] Fix System Prompt updates from Conversations tab (#234812)","sha":"540e69f494bb36fd269f418d4dd03d29c13b8eb1"}},"sourceBranch":"main","suggestedTargetBranches":["8.19","9.1"],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/234812","number":234812,"mergeCommit":{"message":"[Security assistant] Fix System Prompt updates from Conversations tab (#234812)","sha":"540e69f494bb36fd269f418d4dd03d29c13b8eb1"}},{"branch":"8.19","label":"v8.19.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.1","label":"v9.1.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Steph Milovic <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Sep 12, 2025
…ns tab (#234812) (#234927) # Backport This will backport the following commits from `main` to `9.1`: - [[Security assistant] Fix System Prompt updates from Conversations tab (#234812)](#234812) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Steph Milovic","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-09-12T14:23:10Z","message":"[Security assistant] Fix System Prompt updates from Conversations tab (#234812)","sha":"540e69f494bb36fd269f418d4dd03d29c13b8eb1","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team: SecuritySolution","Team:Security Generative AI","backport:version","v9.2.0","v8.19.5","v9.1.5"],"title":"[Security assistant] Fix System Prompt updates from Conversations tab","number":234812,"url":"https://github.com/elastic/kibana/pull/234812","mergeCommit":{"message":"[Security assistant] Fix System Prompt updates from Conversations tab (#234812)","sha":"540e69f494bb36fd269f418d4dd03d29c13b8eb1"}},"sourceBranch":"main","suggestedTargetBranches":["8.19","9.1"],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/234812","number":234812,"mergeCommit":{"message":"[Security assistant] Fix System Prompt updates from Conversations tab (#234812)","sha":"540e69f494bb36fd269f418d4dd03d29c13b8eb1"}},{"branch":"8.19","label":"v8.19.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.1","label":"v9.1.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Steph Milovic <[email protected]>
KodeRad
pushed a commit
to KodeRad/kibana
that referenced
this pull request
Sep 15, 2025
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Sep 24, 2025
niros1
pushed a commit
that referenced
this pull request
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Enable repeated System Prompt navigation from Conversations tab
Problem
Users could navigate from Conversations > System Prompts > Add System Prompt successfully the first time, but subsequent attempts would fail. The issue was that the
selectedSettingsTabcontext state wasn't being properly cleared after navigation, preventing users from accessing the System Prompts tab again when editing conversations.Steps to Reproduce (Previous Behavior)
Previous behavior
Expected Behavior (After Fix)
Solution
Added missing
setSelectedSettingsTab(null)call in theuseEffecthook withinAssistantSettingsManagementcomponent to properly clear the context settings tab state after navigation, enabling repeated navigation attempts.Fixes #197962