Skip to content

Conversation

@e40pud
Copy link
Contributor

@e40pud e40pud commented Sep 12, 2025

Backport

This will backport the following commits from main to 9.1:

Questions ?

Please refer to the Backport tool documentation

…date (elastic#233288)

## Summary

Part of
Epic: elastic/security-team#12768
Meta: elastic/security-team#13657

In my [previous PR](elastic#232288), I
accidentally removed "retry on conflict"
[logic](https://github.com/elastic/kibana/pull/232288/files#r2305375978).

These changes add a retry logic on bulk update conflicts. For that we
use a `retry_on_conflict` option
https://www.elastic.co/docs/api/doc/elasticsearch/operation/operation-bulk#operation-bulk-body-application-json-update-retry_on_conflict.
The retry count is set to 3 to match previous behaviour.

cc @stephmilovic

(cherry picked from commit 8170cff)

# Conflicts:
#	x-pack/solutions/security/plugins/elastic_assistant/server/ai_assistant_data_clients/conversations/index.test.ts
@e40pud e40pud added the backport This PR is a backport of another PR label Sep 12, 2025
@e40pud e40pud enabled auto-merge (squash) September 12, 2025 08:30
@e40pud e40pud requested a review from stephmilovic September 12, 2025 08:31
@elasticmachine
Copy link
Contributor

elasticmachine commented Sep 12, 2025

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #6 / getConversation it returns a conversation as expected if the conversation is found
  • [job] [logs] Jest Tests #6 / getConversation it returns a conversation as expected if the conversation is found

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
elasticAssistant 42 41 -1

Total ESLint disabled count

id before after diff
elasticAssistant 50 49 -1

History

@e40pud e40pud merged commit bdc6ee9 into elastic:9.1 Sep 12, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants