-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[Streams] Add data quality badge to Streams table #234946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ElenaStoeva
merged 37 commits into
elastic:main
from
ElenaStoeva:streams/data-quality-badge
Sep 18, 2025
Merged
Changes from 4 commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
1831378
[Streams] Add data quality badge to Streams table
ElenaStoeva 6847eb0
Merge branch 'main' into streams/data-quality-badge
ElenaStoeva cee73e4
Handle failed requests
ElenaStoeva 3c73798
Merge branch 'main' into streams/data-quality-badge
ElenaStoeva f88420e
[CI] Auto-commit changed files from 'node scripts/yarn_deduplicate'
kibanamachine 0d4cb5f
[CI] Auto-commit changed files from 'node scripts/eslint_all_files --…
kibanamachine 7217c4b
Reuse badge component from Data quality
ElenaStoeva 5636dd5
Address feedback
ElenaStoeva 4d6ef15
Move indicator to package
ElenaStoeva 9a34754
[CI] Auto-commit changed files from 'node scripts/eslint_all_files --…
kibanamachine 32a4703
Fix ci errors
ElenaStoeva e54eab4
Merge branch 'streams/data-quality-badge' of https://github.com/Elena…
ElenaStoeva cd87ba5
Revert "Move indicator to package"
ElenaStoeva c8ab667
Address feedback
ElenaStoeva 14efc9b
[CI] Auto-commit changed files from 'node scripts/yarn_deduplicate'
kibanamachine 2de9eb8
[CI] Auto-commit changed files from 'node scripts/eslint_all_files --…
kibanamachine 0c19f99
[CI] Auto-commit changed files from 'node scripts/yarn_deduplicate'
kibanamachine 448f9d5
Remove types from package
ElenaStoeva d480e5f
Add failed docs to histogram query
ElenaStoeva 27bce88
Revert exporting to package
ElenaStoeva 1ed398b
Merge branch 'main' into streams/data-quality-badge
ElenaStoeva f2599e6
Revert translation changes
ElenaStoeva e81687a
Remove constants from package
ElenaStoeva d0998b0
Update bundle size limit
ElenaStoeva 878168b
Merge branch 'main' into streams/data-quality-badge
ElenaStoeva ab1eda4
centralize fetching
flash1293 2eae0d7
remove debug thingy
flash1293 982f1ad
Update x-pack/platform/plugins/shared/streams_app/public/components/s…
ElenaStoeva f07c843
Update x-pack/platform/plugins/shared/streams_app/public/components/s…
ElenaStoeva ef94bb5
Update x-pack/platform/plugins/shared/streams_app/public/hooks/use_st…
ElenaStoeva 3ed5d15
Update x-pack/platform/plugins/shared/streams_app/public/components/s…
ElenaStoeva 54d2770
Address feedback
ElenaStoeva bef0633
fix type
flash1293 63a25fd
Merge branch 'main' into streams/data-quality-badge
ElenaStoeva 8c80cdd
Increase bundle size limit for datasetQuality
ElenaStoeva abfae36
Merge branch 'main' into streams/data-quality-badge
ElenaStoeva b1db85e
Merge branch 'main' into streams/data-quality-badge
yngrdyn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 changes: 9 additions & 0 deletions
9
x-pack/platform/packages/private/kbn-data-quality/common/utils/index.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License | ||
| * 2.0; you may not use this file except in compliance with the Elastic License | ||
| * 2.0. | ||
| */ | ||
|
|
||
| export * from './deep_compact_object'; | ||
| export * from './quality_helpers'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,4 +6,3 @@ | |
| */ | ||
|
|
||
| export * from './dataset_name'; | ||
| export * from './quality_helpers'; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
48 changes: 48 additions & 0 deletions
48
...form/plugins/shared/streams_app/public/components/stream_list_view/data_quality_badge.tsx
ElenaStoeva marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License | ||
| * 2.0; you may not use this file except in compliance with the Elastic License | ||
| * 2.0. | ||
| */ | ||
|
|
||
| import React from 'react'; | ||
| import type { IconType } from '@elastic/eui'; | ||
| import { useEuiTheme, EuiBadge, EuiText } from '@elastic/eui'; | ||
| import { i18n } from '@kbn/i18n'; | ||
| import type { QualityIndicators } from '@kbn/data-quality/common'; | ||
|
|
||
| export const DataQualityBadge = ({ quality }: { quality: QualityIndicators }) => { | ||
| const { euiTheme } = useEuiTheme(); | ||
|
|
||
| const qualityColors: Record<QualityIndicators, string> = { | ||
| poor: euiTheme.colors.backgroundLightDanger, | ||
| degraded: euiTheme.colors.backgroundLightWarning, | ||
| good: euiTheme.colors.backgroundLightSuccess, | ||
| }; | ||
|
|
||
| const qualityTextColors: Record<QualityIndicators, string> = { | ||
| poor: euiTheme.colors.textDanger, | ||
| degraded: euiTheme.colors.textWarning, | ||
| good: euiTheme.colors.textSuccess, | ||
| }; | ||
|
|
||
| const qualityIcons: Record<QualityIndicators, IconType> = { | ||
| poor: 'error', | ||
| degraded: 'warning', | ||
| good: 'checkCircle', | ||
| }; | ||
|
|
||
| const qualityTexts: Record<QualityIndicators, string> = { | ||
| poor: i18n.translate('xpack.streams.dataQualityBadge.poor', { defaultMessage: 'Poor' }), | ||
| degraded: i18n.translate('xpack.streams.dataQualityBadge.degraded', { defaultMessage: 'Degraded' }), | ||
| good: i18n.translate('xpack.streams.dataQualityBadge.good', { defaultMessage: 'Good' }), | ||
| }; | ||
|
|
||
| return ( | ||
| <EuiBadge color={qualityColors[quality]} iconType={qualityIcons[quality]}> | ||
| <EuiText color={qualityTextColors[quality]} size="relative"> | ||
| {qualityTexts[quality]} | ||
| </EuiText> | ||
| </EuiBadge> | ||
| ); | ||
| }; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.