-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[ES|QL] Adds pagination on the history component #235051
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
stratoula
merged 2 commits into
elastic:main
from
stratoula:history-component-pagination
Sep 17, 2025
Merged
[ES|QL] Adds pagination on the history component #235051
stratoula
merged 2 commits into
elastic:main
from
stratoula:history-component-pagination
Sep 17, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
|
stratoula
commented
Sep 15, 2025
| const scrollBarStyles = euiScrollBarStyles(theme); | ||
| const [isDiscardQueryModalVisible, setIsDiscardQueryModalVisible] = useState(false); | ||
|
|
||
| const { sorting, onTableChange } = useEuiTablePersist<QueryHistoryItem>({ |
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was causing bugs with pagination and I dont think it is important to persist the sorting here
Contributor
|
Pinging @elastic/kibana-esql (Team:ESQL) |
bartoval
approved these changes
Sep 17, 2025
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Sep 24, 2025
## Summary Adds pagination on the history table as it is not so performant for many items - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <[email protected]>
niros1
pushed a commit
that referenced
this pull request
Sep 30, 2025
## Summary Adds pagination on the history table as it is not so performant for many items - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <[email protected]>
rylnd
pushed a commit
to rylnd/kibana
that referenced
this pull request
Oct 17, 2025
## Summary Adds pagination on the history table as it is not so performant for many items - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:skip
This PR does not require backporting
Feature:ES|QL
ES|QL related features in Kibana
release_note:skip
Skip the PR/issue when compiling release notes
Team:ESQL
ES|QL related features in Kibana t//
v9.2.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds pagination on the history table as it is not so performant for many items