-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[FTR] Unskiped test #235064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FTR] Unskiped test #235064
Conversation
|
Thank you for the fix @elena-shostak! Not sure why this wasn't caught by the PR CI and only started failing on merge. |
💚 Build Succeeded
Metrics [docs]
|
yeah, probably because of |
azasypkin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
| 'xpack.observabilityAiAssistantManagement.spacesEnabled (boolean?)', | ||
| 'xpack.observabilityAiAssistantManagement.visibilityEnabled (boolean?)', | ||
| 'xpack.observabilityShared.unsafe.investigativeExperienceEnabled (boolean?)', | ||
| 'xpack.observability.managedOtlpServiceUrl (string?)', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mykolaharmash since you originally exposed this entry in #234188 - is there anything sensitive in this URL that we don’t want all authenticated users to see? For example, can it include credentials like http://**username:password**@example.com, or should it be only visible to users who have access to the application that uses it, or something else along these lines? Exposing this value through exposeToBrowser makes it visible to any authenticated Kibana user irrespective to their permissions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@azasypkin it's safe to expose it to the browser because this URL will be shown in the UI anyways. It won't include any credentials and will require API key to make requests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, great, thanks for confirming!
## Summary Unskiped FTR test. __Closes: https://github.com/elastic/kibana/issues/235052__
## Summary Unskiped FTR test. __Closes: https://github.com/elastic/kibana/issues/235052__
Summary
Unskiped FTR test.
Closes: #235052