Skip to content

Conversation

@elena-shostak
Copy link
Contributor

Summary

Unskiped FTR test.

Closes: #235052

@elena-shostak elena-shostak added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting FTR labels Sep 15, 2025
@mykolaharmash
Copy link
Contributor

mykolaharmash commented Sep 15, 2025

Thank you for the fix @elena-shostak! Not sure why this wasn't caught by the PR CI and only started failing on merge.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

@elena-shostak elena-shostak marked this pull request as ready for review September 15, 2025 14:32
@elena-shostak elena-shostak requested a review from a team as a code owner September 15, 2025 14:32
@elena-shostak
Copy link
Contributor Author

Thank you for the fix @elena-shostak! Not sure why this was caught by the PR CI and only started failing on merge.

yeah, probably because of LIMIT_SOLUTIONS='observability' flag, but we are waiting for ops team to chime in

Copy link
Member

@azasypkin azasypkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

'xpack.observabilityAiAssistantManagement.spacesEnabled (boolean?)',
'xpack.observabilityAiAssistantManagement.visibilityEnabled (boolean?)',
'xpack.observabilityShared.unsafe.investigativeExperienceEnabled (boolean?)',
'xpack.observability.managedOtlpServiceUrl (string?)',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mykolaharmash since you originally exposed this entry in #234188 - is there anything sensitive in this URL that we don’t want all authenticated users to see? For example, can it include credentials like http://**username:password**@example.com, or should it be only visible to users who have access to the application that uses it, or something else along these lines? Exposing this value through exposeToBrowser makes it visible to any authenticated Kibana user irrespective to their permissions.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@azasypkin it's safe to expose it to the browser because this URL will be shown in the UI anyways. It won't include any credentials and will require API key to make requests.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, great, thanks for confirming!

@elena-shostak elena-shostak merged commit 45f67a9 into elastic:main Sep 15, 2025
21 checks passed
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Sep 24, 2025
niros1 pushed a commit that referenced this pull request Sep 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting FTR release_note:skip Skip the PR/issue when compiling release notes v9.2.0

Projects

None yet

5 participants