[deps] Update vega to 6.x #238618
[deps] Update vega to 6.x #238618
Conversation
…urce-definitions/scripts/fix-location-collection.ts'
…t --include-path /api/status --include-path /api/alerting/rule/ --include-path /api/alerting/rules --include-path /api/actions --include-path /api/security/role --include-path /api/spaces --include-path /api/streams --include-path /api/fleet --include-path /api/saved_objects/_import --include-path /api/saved_objects/_export --include-path /api/maintenance_window --include-path /api/agent_builder --update'
… into markov-2025_10_13-update_vega_6
markov00
force-pushed
the
2025_10_13-update_vega_6
branch
from
dd9445b to
fd08d83
Compare
markov00
added
Team:Visualizations
|
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
There was a problem hiding this comment.
LGTM! Thank you for this. The new dep has a good health score, but for posterity's sake, could you include the answers to all of the check list questions in the description?
src/platform/packages/shared/kbn-test/src/jest/setup/mocks.vega.js
Outdated
Show resolved
Hide resolved
@jeramysoucy This dependency is actually not a new one, it was already available as dependency of |
@markov00 Ah, ok. Thanks for clarifying that. I have no concern at all to keep it in, especially if the alternative is unfavorable. I just wanted to make sure we documented any alternatives and the reason for picking this one. |
alvarezmelissa87
left a comment
alvarezmelissa87
left a comment
There was a problem hiding this comment.
Tested and ML changes LGTM ⚡
💔 Build Failed
Failed CI StepsHistory
cc @markov00 |
10 participants
Summary
Update Vega dependencies to 6.x.
This pull request updates the project's Vega and Vega-Lite dependencies to their latest major versions.
Dependency Upgrades and Import Handling
Upgraded
vega,vega-lite,vega-interpreter,vega-tooltip, and related libraries to their latest major versions inpackage.json, and updated their import paths throughout the codebase.Removed legacy Webpack and Storybook configuration for the old
vegabuild, includingnoParserules and aliases, and updated the import resolver to point to the newvega-liteandvega-tooltipbuild directories.Testing and TypeScript Support
vegaandvega-liteto ensure tests run correctly with the new versions, and updated Jest transform ignore patterns to support new Vega-related packages.tsconfig.base.jsonto include type definitions forvega-liteandvega-tooltip.Babel and Build Tools
@babel/plugin-syntax-import-attributesto dependencies and Babel preset to enable the new import attributes syntax.Test Snapshots
### Dependency added@babel/plugin-syntax-import-attributes- [x] Purpose: This plugin allows Babel to parse the JavaScript Import Attributes syntax without transforming it.- [x] Justification: Vega 6 and Vega-Lite uses this import attribute syntax in multiple places, for examplehttps://github.com/vega/vega/blob/b89378d5b8ac3af85a2c2f51112345a1ba50db99/packages/vega/index.js#L24
- [x] Alternatives explored: I was trying using@babel/generator's as suggested here but wasn't able to properly make it working.- [x] Existing dependencies: As described above, it can probably be possible to use babel generators for that but it was not working.The initial use of
@babel/plugin-syntax-import-attributeswas replace with the use of@babel/generatoras suggested here