[ES|QL] Distinguish variables suggestions and Create control one #243934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 24, 2025
stratoula
added
Feature:ES|QL
Contributor
|
Pinging @elastic/kibana-esql (Team:ESQL) |
momovdg
approved these changes
Nov 26, 2025
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
Page load bundle
History
|
eokoneyo
pushed a commit
to eokoneyo/kibana
that referenced
this pull request
Dec 2, 2025
…stic#243934) ## Summary Part of elastic#238473 This PR is a necessary step before chaining controls. In the chaining controls we want to get variables suggestions but we do not want to get the "Create control" suggestion. This PR is accomplishing this with some small changes on how we treat the supportsControl prop in the editor. Note: I decided to move this away from the elastic#242909 as the presentation team is working on a big refactoring so they will take care of the chaining controls. ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #238473
This PR is a necessary step before chaining controls. In the chaining controls we want to get variables suggestions but we do not want to get the "Create control" suggestion.
This PR is accomplishing this with some small changes on how we treat the supportsControl prop in the editor.
Note: I decided to move this away from the #242909 as the presentation team is working on a big refactoring so they will take care of the chaining controls.
Checklist