[Streams] Make feature detection prompt route #244094

shahzad31 · 2025-11-25T08:36:27Z

Summary

Added a route for setting and getting a prompt for features detection , prompt is for now called systemPromptTemplate, perhaps should be more generic?

Get Route

GET /internal/streams/_prompts

it will return default prompt if it hasn't been modified yet

Set route

PUT kbn:/internal/streams/_prompts
{
    "systemPromptTemplate":"test"
}

…atus --include-path /api/alerting/rule/ --include-path /api/alerting/rules --include-path /api/actions --include-path /api/security/role --include-path /api/spaces --include-path /api/streams --include-path /api/fleet --include-path /api/saved_objects/_import --include-path /api/saved_objects/_export --include-path /api/maintenance_window --include-path /api/agent_builder --update

…tion_tests/ci_checks

x-pack/platform/packages/shared/kbn-streams-ai/src/significant_events/prompt.ts

...latform/packages/shared/kbn-streams-ai/src/significant_events/generate_significant_events.ts

miltonhultgren

Tested locally, works as expected ✅

I feel like some of the naming makes it to bound to significant events, perhaps we need to make this just a bit more generic so we can tweak the prompts for feature identification and other use cases in the future?
We can also do that in a follow up PR if you feel it would be much work.

x-pack/platform/packages/shared/kbn-streams-ai/src/significant_events/prompt.ts

.../plugins/shared/streams/server/lib/saved_objects/significant_events/promps_config_service.ts

...platform/plugins/shared/streams/server/lib/significant_events/generate_significant_events.ts

x-pack/platform/plugins/shared/streams/server/routes/internal/streams/features/route.ts

…into config-prompts

.../plugins/shared/streams/server/lib/saved_objects/significant_events/promps_config_service.ts

x-pack/platform/plugins/shared/streams/server/routes/internal/streams/features/route.ts

elasticmachine · 2025-12-03T17:36:53Z

💔 Build Failed

Buildkite Build
Commit: 145a33c

Failed CI Steps

History

klacabane · 2025-12-03T19:12:37Z

x-pack/platform/plugins/shared/streams/server/routes/internal/streams/prompts/route.ts

+  ...setFeaturesPromptRoute,
+  ...getFeaturesPromptRoute,
+  ...resetFeaturesPromptRoute,


we can remove Features from the names

klacabane · 2025-12-03T19:23:05Z

x-pack/platform/plugins/shared/streams/server/lib/saved_objects/register_saved_objects.ts

+
+import { getSignificantEventPrompts } from './significant_events/prompts_config';
+
+export const readStreamSavedObjects = (savedObjectsService: SavedObjectsServiceSetup) => {


registerStreamsSavedObjects ?

klacabane · 2025-12-03T19:27:04Z

...latform/plugins/shared/streams/server/lib/saved_objects/significant_events/prompts_config.ts

+ */
+import type { SavedObjectsType } from '@kbn/core/server';
+
+export const significantEventsPromptsType = 'significant-events-prompts';


any reason to bind this naming to significant events ? should likely be more generic

klacabane · 2025-12-03T19:30:47Z

.../plugins/shared/streams/server/lib/saved_objects/significant_events/promps_config_service.ts

+    const existing = await this.getPrompt();
+
+    this.logger.debug('Creating significant events prompt');
+    // pass options through so callers can set id if they want; don't force overwrite


is this true ? seems like we always force an id

klacabane · 2025-12-03T19:32:40Z

.../plugins/shared/streams/server/lib/saved_objects/significant_events/promps_config_service.ts

+        significantEventsPromptsType,
+        SINGLETON_PROMPTS_ID


perhaps the first one should be more generic streamsPromptsType and the second one more specific SIGNIFICANT_EVENTS_PROMPTS_ID

klacabane · 2025-12-03T19:49:14Z

...latform/plugins/shared/streams/server/lib/saved_objects/significant_events/prompts_config.ts

+        type: {
+          type: 'keyword',
+        },


what is this type property, I don't see it persisted in the attributes

klacabane · 2025-12-03T19:52:54Z

.../plugins/shared/streams/server/lib/saved_objects/significant_events/promps_config_service.ts

+   * attributes is a plain object (e.g. { name, systemPromptTemplate, userPromptTemplate, inputExample })
+   * Note: no forced singleton id/overwrite — allow multiple prompt objects (user-created).
+   */
+  async createPrompt(attributes: PromptsConfigAttributes, options?: SavedObjectsCreateOptions) {


nit but this does an upsert

github-actions bot added the author:actionable-obs PRs authored by the actionable obs team label Nov 25, 2025

shahzad31 added the Feature:SignificantEvents label Nov 25, 2025

add prompts route

cb04a27

shahzad31 force-pushed the config-prompts branch from 4fdc5ec to cb04a27 Compare December 3, 2025 07:32

shahzad31 changed the title ~~[Significant Events] Make generation configurable~~ [Streams] Make feature detection prompt route Dec 3, 2025

shahzad31 marked this pull request as ready for review December 3, 2025 07:37

shahzad31 requested review from a team as code owners December 3, 2025 07:37

shahzad31 added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting labels Dec 3, 2025

kibanamachine added 2 commits December 3, 2025 07:52

Changes from node scripts/check_mappings_update --fix

bce9e09

elastic-vault-github-plugin-prod bot requested a review from a team as a code owner December 3, 2025 07:52

Changes from make api-docs

51d9742

elastic-vault-github-plugin-prod bot requested a review from a team as a code owner December 3, 2025 08:06

shahzad31 and others added 3 commits December 3, 2025 09:50

fix types

b99f56e

update count

fb21e06

Changes from node scripts/jest_integration -u src/core/server/integra…

d1519a1

…tion_tests/ci_checks

miltonhultgren reviewed Dec 3, 2025

View reviewed changes

x-pack/platform/packages/shared/kbn-streams-ai/src/significant_events/prompt.ts Outdated Show resolved Hide resolved

miltonhultgren reviewed Dec 3, 2025

View reviewed changes

...latform/packages/shared/kbn-streams-ai/src/significant_events/generate_significant_events.ts Outdated Show resolved Hide resolved

miltonhultgren approved these changes Dec 3, 2025

View reviewed changes

shahzad31 added 2 commits December 3, 2025 16:34

PR feedback

5e5fc28

Merge branch 'config-prompts' of https://github.com/shahzad31/kibana …

ecd6918

…into config-prompts

ruflin reviewed Dec 3, 2025

View reviewed changes

mdbirnstiehl approved these changes Dec 3, 2025

View reviewed changes

shahzad31 added 3 commits December 3, 2025 17:50

code clean up

09d0c50

code clean up

b13b9fb

last final cleanup

145a33c

klacabane reviewed Dec 3, 2025

View reviewed changes


		import { getSignificantEventPrompts } from './significant_events/prompts_config';

		export const readStreamSavedObjects = (savedObjectsService: SavedObjectsServiceSetup) => {

[Streams] Make feature detection prompt route #244094

Are you sure you want to change the base?

[Streams] Make feature detection prompt route #244094

Uh oh!

Conversation

shahzad31 commented Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Get Route

Set route

Uh oh!

Uh oh!

Uh oh!

miltonhultgren left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

elasticmachine commented Dec 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💔 Build Failed

Failed CI Steps

History

Uh oh!

klacabane Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

klacabane Dec 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

klacabane Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

klacabane Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

klacabane Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

klacabane Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

klacabane Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

shahzad31 commented Nov 25, 2025 •

edited

Loading

elasticmachine commented Dec 3, 2025 •

edited

Loading

klacabane Dec 3, 2025 •

edited

Loading