Skip to content

[Lens] Add file to test top N (terms aggregation) #244548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[Lens] Add file to test top N (terms aggregation) #244548

wants to merge 2 commits into from
+153 −0

Conversation

@mariairiartef
Copy link
Contributor

@mariairiartef mariairiartef commented Nov 27, 2025 •
edited
Loading

Summary

Part of #241635

Adds test case for testing getESQLForLayer method with a terms aggregation input so we increase the test coverage.

Checklist

  • Unit or functional tests were updated or added to match the most common scenarios
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines
  • Review the backport guidelines and apply applicable backport:* labels.

@mariairiartef mariairiartef added testing Issues related to tests. Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// release_note:skip Skip the PR/issue when compiling release notes Feature:Lens backport:skip This PR does not require backporting labels Nov 28, 2025
@mariairiartef mariairiartef marked this pull request as ready for review December 1, 2025 10:17
@mariairiartef mariairiartef requested a review from a team as a code owner December 1, 2025 10:17
@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 1, 2025

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 1, 2025 •
edited
Loading

💔 Build Failed

Failed CI Steps

History

walterra
walterra approved these changes Dec 3, 2025
View reviewed changes
x-pack/platform/plugins/shared/lens/public/datasources/form_based/to_esql_top_n.test.ts

import { getESQLForLayer } from './to_esql';

const defaultUiSettingsGet = (key: string) => {
Copy link
Contributor

@walterra walterra Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nits: We could rename the file to to_esql.top_n.test.ts - it's a pattern used in other places so the part before the first dot in the filename is the same as the original code file it refers to. In this file (and looks like in to_esql.test.s too) we could prefix all the testing data with const mock... .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@walterra walterra walterra approved these changes

@nickofthyme nickofthyme nickofthyme approved these changes

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// testing Issues related to tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mariairiartef @elasticmachine @walterra @nickofthyme