-
Notifications
You must be signed in to change notification settings - Fork 8.5k
Add support for essentials and ease tiers in Scout #244553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for essentials and ease tiers in Scout #244553
Conversation
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
| ...defaultConfig.kbnTestServer, | ||
| serverArgs: [ | ||
| ...defaultConfig.kbnTestServer.serverArgs, | ||
| '--serverless=security', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just to make sure: serverless arg should be security. Not EASE or essentials?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, serverless arg should be security, EASE and essentials refers to the tier used in the security project.
dmlemeshko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@MadameSheema I think it would be better to backport PR to "all-open" to avoid merge conflicts in the future even though we don't run svl tests in those branches.
With this PR tests won't be run for tiers, you need to make changes in
kibana/.buildkite/scripts/steps/test/scout_configs.sh
Lines 62 to 74 in 4fc8027
| # Define run modes based on group | |
| declare -A RUN_MODES | |
| RUN_MODES["platform"]="--stateful --serverless=es --serverless=oblt --serverless=security" | |
| RUN_MODES["observability"]="--stateful --serverless=oblt --serverless=oblt-logs-essentials" | |
| RUN_MODES["search"]="--stateful --serverless=es" | |
| RUN_MODES["security"]="--stateful --serverless=security" | |
| # Define serverless-only run modes based on group | |
| declare -A RUN_MODES_SERVERLESS_ONLY | |
| RUN_MODES_SERVERLESS_ONLY["platform"]="--serverless=es --serverless=oblt --serverless=security" | |
| RUN_MODES_SERVERLESS_ONLY["observability"]="--serverless=oblt --serverless=oblt-logs-essentials" | |
| RUN_MODES_SERVERLESS_ONLY["search"]="--serverless=es" | |
| RUN_MODES_SERVERLESS_ONLY["security"]="--serverless=security" |
I'm not sure if we need to run all the platform tests for each tier, let me know you thoughts
Thank you for pointing this out! I'll make the changes 😊
I’m not sure because I don’t know what the platform tests cover. Could you please share the link with me? |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
|
delanni
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
scout_configs.sh 👍
Side question:
@elastic/appex-qa - do you think the tools/scripts around scout are located close enough, so we could share or hand over ownership of these scripts? You probably know more about it, so your approval might be more relevant
|
Starting backport for target branches: 8.19, 9.1, 9.2 |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
## Summary Adds support for the essentials and ease severless tiers to the Scout testing framework, enabling local server startup with the Security Essentials and Security EASE tier configuration. ### Testing * Verified that node scripts/scout.js start-server --serverless=security-essentials successfully starts the environment * Verified that node scripts/scout.js start-server --serverless=security-ease successfully starts the environment --------- Co-authored-by: kibanamachine <[email protected]>
Summary
Adds support for the essentials and ease severless tiers to the Scout testing framework, enabling local server startup with the Security Essentials and Security EASE tier configuration.
Testing