[ResponseOps][Connector V2] Make getAxiosInstance function available from the action client
#244619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adcoelho
changed the title
getAxiosInstance function available from the action client
adcoelho
force-pushed
the
expose-get-axios
branch
from
75b811a to
63ce0b3
Compare
adcoelho
force-pushed
the
expose-get-axios
branch
from
b931ed7 to
9bee84f
Compare
ymao1
approved these changes
Dec 1, 2025
Contributor
ymao1
left a comment
ymao1
left a comment
There was a problem hiding this comment.
LGTM. Would be good to see a functional test that tests getting a preconfigured axios instance using the actions client.
...shared/actions/server/application/connector/methods/get_axios_instance/get_axios_instance.ts
Show resolved
Hide resolved
| }); | ||
|
|
||
| // check to see if it's in memory connector before fetching secrets | ||
| const inMemoryAction = inMemoryConnectors.find( |
Contributor
There was a problem hiding this comment.
nit: is there a way to set the flag in the above check for inmemory connector?
...d/actions/server/application/connector/methods/get_axios_instance/get_axios_instance.test.ts
Outdated
Show resolved
Hide resolved
cnasikas
added
release_note:skip
Contributor
|
Pinging @elastic/response-ops (Team:ResponseOps) |
cnasikas
added
backport:version
Contributor
💚 Build Succeeded
Metrics [docs]
History
cc @adcoelho |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #243808
Summary
Makes the utility function
getAxiosInstanceWithAuthaccessible outside the plugin via theactionsClient.For a given connector ID, this function validates the secrets and returns an axios instance properly configured with authentication.