Skip to content

Use separate expect clauses to check only necessary response fields. #244666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 1, 2025
Merged

Use separate expect clauses to check only necessary response fields. #244666

merged 3 commits into from
Dec 1, 2025

Conversation

@ThomThomson
Copy link
Contributor

@ThomThomson ThomThomson commented Nov 28, 2025

Summary

Fixes #244448 by using more explicit expects.

@ThomThomson
Copy link
Contributor Author

ThomThomson commented Nov 28, 2025

@elasticmachine merge upstream

@ThomThomson
Copy link
Contributor Author

ThomThomson commented Nov 28, 2025

/ci

@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 29, 2025

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

@ThomThomson ThomThomson marked this pull request as ready for review December 1, 2025 18:02
@ThomThomson ThomThomson requested a review from a team as a code owner December 1, 2025 18:02
@ThomThomson ThomThomson added loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. labels Dec 1, 2025
nreese
nreese approved these changes Dec 1, 2025
View reviewed changes
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kibana-presentation changes LGTM - thanks for updating this test to be less noisy unless something maps uses in the response changes.
code review only

@ThomThomson ThomThomson added the backport:skip This PR does not require backporting label Dec 1, 2025
@ThomThomson
Copy link
Contributor Author

ThomThomson commented Dec 1, 2025

@elasticmachine merge upstream

@ThomThomson ThomThomson merged commit d52fcec into elastic:main Dec 1, 2025
12 checks passed
@pheyos pheyos mentioned this pull request Dec 2, 2025
Closed
NicholasPeretti pushed a commit to NicholasPeretti/kibana that referenced this pull request Dec 2, 2025
@ThomThomson @NicholasPeretti
Use separate expect clauses to check only necessary response fields. (e…
cde2c8b 
…lastic#244666)

uses more explicit expects on for "maps endpoints apis search ES|QL should return getColumns response in expected shape"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nreese nreese nreese approved these changes

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes v9.3.0

Projects

None yet

Milestone

No milestone

4 participants

@ThomThomson @elasticmachine @nreese @kibanamachine