[ES|QL] Do not call "pre-build" script when building grammar #244718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vadimkibana
added
review
release_note:skip
Contributor
|
Pinging @elastic/kibana-esql (Team:ESQL) |
stratoula
approved these changes
Dec 1, 2025
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest FailuresMetrics [docs]
|
tkajtoch
pushed a commit
to tkajtoch/kibana
that referenced
this pull request
Dec 1, 2025
…#244718) ## Summary This change should avoid calling prebuild script, which tries to install ANTLR with Brew (Mac only). Hopefully fixes: https://buildkite.com/elastic/kibana-es-ql-grammar-sync/builds/180#019ad849-f427-4b56-9468-52462c4688da My understanding that `yarn build:antlr4` was also triggering `yarn prebuild:antlr4` automatically, but `yarn prebuild:antlr4` is meant only for local execution on Mac. See: > Pre and post commands with matching names will be run for those as well (e.g. premyscript, myscript, postmyscript). Scripts from dependencies can be run with npm explore <pkg> -- npm run <stage>. - https://docs.npmjs.com/cli/v8/using-npm/scripts
NicholasPeretti
pushed a commit
to NicholasPeretti/kibana
that referenced
this pull request
Dec 2, 2025
…#244718) ## Summary This change should avoid calling prebuild script, which tries to install ANTLR with Brew (Mac only). Hopefully fixes: https://buildkite.com/elastic/kibana-es-ql-grammar-sync/builds/180#019ad849-f427-4b56-9468-52462c4688da My understanding that `yarn build:antlr4` was also triggering `yarn prebuild:antlr4` automatically, but `yarn prebuild:antlr4` is meant only for local execution on Mac. See: > Pre and post commands with matching names will be run for those as well (e.g. premyscript, myscript, postmyscript). Scripts from dependencies can be run with npm explore <pkg> -- npm run <stage>. - https://docs.npmjs.com/cli/v8/using-npm/scripts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change should avoid calling prebuild script, which tries to install ANTLR with Brew (Mac only). Hopefully fixes: https://buildkite.com/elastic/kibana-es-ql-grammar-sync/builds/180#019ad849-f427-4b56-9468-52462c4688da
My understanding that
yarn build:antlr4was also triggeringyarn prebuild:antlr4automatically, butyarn prebuild:antlr4is meant only for local execution on Mac.See: