[Metrics][Discover] use lastReloadRequestTime from fetchParam #244761
+16
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crespocarlos
added
release_note:skip
Contributor
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
miloszmarcinkowski
approved these changes
Dec 1, 2025
Contributor
miloszmarcinkowski
left a comment
miloszmarcinkowski
left a comment
There was a problem hiding this comment.
LGTM, code review only
tkajtoch
pushed a commit
to tkajtoch/kibana
that referenced
this pull request
Dec 1, 2025
…c#244761) part of [239158](elastic#239158) ## Summary This PR is a follow-up from the changes made for [239158](elastic#239158). `lastReloadRequestTime` was receiving `Date.now()` and this was causing the chart to reload whenever it returned to the viewport. `fetchParams` provides a `lastReloadRequestTime` attribute, which is safer to use ### How to test - Start a local Kibana instance and point it to an oblt cluster ```yml feature_flags.overrides: metricsExperienceEnabled: true ``` - Navigate to Discover and Switch to ESQL mode - After the grid loads, scroll up or down. The charts should not try to load data. --------- Co-authored-by: kibanamachine <[email protected]>
NicholasPeretti
pushed a commit
to NicholasPeretti/kibana
that referenced
this pull request
Dec 2, 2025
…c#244761) part of [239158](elastic#239158) ## Summary This PR is a follow-up from the changes made for [239158](elastic#239158). `lastReloadRequestTime` was receiving `Date.now()` and this was causing the chart to reload whenever it returned to the viewport. `fetchParams` provides a `lastReloadRequestTime` attribute, which is safer to use ### How to test - Start a local Kibana instance and point it to an oblt cluster ```yml feature_flags.overrides: metricsExperienceEnabled: true ``` - Navigate to Discover and Switch to ESQL mode - After the grid loads, scroll up or down. The charts should not try to load data. --------- Co-authored-by: kibanamachine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of 239158
Summary
This PR is a follow-up from the changes made for 239158.
lastReloadRequestTimewas receivingDate.now()and this was causing the chart to reload whenever it returned to the viewport.fetchParamsprovides alastReloadRequestTimeattribute, which is safer to useHow to test