Skip to content

[Stack Alerts] Resolve TS expect error after TypeScript upgrade by validating string array #244791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 2, 2025
Merged

[Stack Alerts] Resolve TS expect error after TypeScript upgrade by validating string array #244791

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
89b1f4e
[Stack Alerts] Resolve TS expect error after TypeScript upgrade by va…
olapawlus Dec 1, 2025
00efac7
Merge branch 'main' into fix/ts-expect-error-upgrade-ts-rule-form
olapawlus Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions ...orm/plugins/shared/stack_alerts/public/rule_types/geo_containment/rule_form/rule_form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,11 @@ export const RuleForm: React.FunctionComponent<
RuleTypeParamsExpressionProps<GeoContainmentAlertParams>
> = (props) => {
function getValidationError(key: string) {
// @ts-expect-error upgrade typescript v5.1.6
return props.errors[key]?.length > 0 && key in props.ruleParams
? (props.errors[key] as string[])[0]
: null;
const error = props.errors[key];
if (Array.isArray(error) && error.length > 0 && key in props.ruleParams) {
return typeof error[0] === 'string' ? error[0] : null;
}
return null;
}

return (
Expand Down