-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[Security Solution][Detection Engine] skips processing gaps in auto backfill scheduler after number of retries reaches configured value #244817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vitaliidm
wants to merge
31
commits into
elastic:main
Choose a base branch
from
vitaliidm:de_9_3/skips_gaps_with_failed_attempts
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+690
−72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ackfill scheduler after number of retries reaches configured value
…ub.com/vitaliidm/kibana into de_9_3/skips_gaps_with_failed_attempts
…ub.com/vitaliidm/kibana into de_9_3/skips_gaps_with_failed_attempts
…ub.com/vitaliidm/kibana into de_9_3/skips_gaps_with_failed_attempts
…ub.com/vitaliidm/kibana into de_9_3/skips_gaps_with_failed_attempts
…ub.com/vitaliidm/kibana into de_9_3/skips_gaps_with_failed_attempts
…ub.com/vitaliidm/kibana into de_9_3/skips_gaps_with_failed_attempts
Contributor
⏳ Build in-progress, with failures
Failed CI StepsHistory
cc @vitaliidm |
Contributor
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
Contributor
|
Pinging @elastic/security-detection-engine (Team:Detection Engine) |
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
History
cc @vitaliidm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:skip
This PR does not require backporting
release_note:skip
Skip the PR/issue when compiling release notes
Team:Detection Engine
Security Solution Detection Engine Area
Team: SecuritySolution
Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
v9.3.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
UI
To test
Enable in kibana.dev.yml
xpack.alerting.gapAutoFillScheduler.enabled: trueThere are two ways to create gaps:
Create and enable a security rule that fails(can be ES|QL query that accesses non-existing field or so on) with a 1-minute interval and 0-second lookback.
After the first run, disable the rule, wait 5 minutes, and then enable it again you should execution error about gaps, and see the gap in the gaps table in the execution tab.
Run the following request (adjust as needed for your environment):
Go to rule details page and observe number of failed attempts in table by hovering over error health indicator in status column. When number of failures becomes greater than number of retries, this gap won't be getting processed anymore
Followup
https://github.com/elastic/security-team/issues/14943