[SLOs] bring back url state in history tab #244833
Merged
+238
−121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
author:actionable-obs
mgiota
added
Team:obs-ux-management
release_note:skip
Contributor
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
mgiota
commented
Dec 2, 2025
| ? `?instanceId=${encodeURIComponent(instanceId)}` | ||
| : ''; | ||
| const path = !!sloId ? `/${encodeURIComponent(sloId)}${queryParams}` : '/'; | ||
| public readonly getLocation = async ({ sloId, instanceId, tabId }: SloDetailsLocatorParams) => { |
Contributor
Author
mgiota
commented
Dec 2, 2025
| import { SloRemoteCallout } from './slo_remote_callout'; | ||
| import { ActionModalProvider } from '../../../context/action_modal'; | ||
|
|
||
| export const TAB_ID_URL_PARAM = 'tabId'; |
Contributor
Author
There was a problem hiding this comment.
TAB_ID_URL_PARAM is not used anywhere, so I removed it. Rest consts were moved to deeplinks package
Contributor
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
History
cc @mgiota |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #244242
This PR: