-
Notifications
You must be signed in to change notification settings - Fork 8.5k
Add registry providers for APM data #244856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
rmyz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small comment
… into data-registry-apm-types
rmyz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
yuliia-fryshko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
APM data can now be retrieved in the observability_agent plugin without depending on the APM plugin like:
this.dataRegistry.getData('apmServiceSummary', {
request,
serviceName,
serviceEnvironment,
start,
end,
transactionType,
});
I think it will be more clean to use constants instead of string like apmServiceSummary. We could add them in observability_agent/common folder . Not blocking, just a thought :)
Otherwise, it looks nice. Thank you for making this change
...ck/solutions/observability/plugins/apm/server/observability_agent/register_data_providers.ts
Show resolved
Hide resolved
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Public APIs missing exports
History
|
Follow-up to #244702
This adds data providers for APM data used in the old contextual insights API (
/internal/observability/assistant/alert_details_contextual_insights). To avoid using that API for the new AI insights we should have a new API that cherry picks the data it needsAPM data can now be retrieved in the
observability_agentplugin without depending on the APM plugin like: