Skip to content

Conversation

@sorenlouv
Copy link
Member

@sorenlouv sorenlouv commented Dec 2, 2025

Follow-up to #244702

This adds data providers for APM data used in the old contextual insights API (/internal/observability/assistant/alert_details_contextual_insights). To avoid using that API for the new AI insights we should have a new API that cherry picks the data it needs

APM data can now be retrieved in the observability_agent plugin without depending on the APM plugin like:

this.dataRegistry.getData('apmServiceSummary', {
  request,
  serviceName,
  serviceEnvironment,
  start,
  end,
  transactionType,
});

@sorenlouv sorenlouv requested review from a team as code owners December 2, 2025 08:53
@botelastic botelastic bot added the Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team label Dec 2, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

Copy link
Contributor

@rmyz rmyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small comment

@sorenlouv sorenlouv added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting labels Dec 2, 2025
Copy link
Contributor

@rmyz rmyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@yuliia-fryshko yuliia-fryshko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APM data can now be retrieved in the observability_agent plugin without depending on the APM plugin like:

this.dataRegistry.getData('apmServiceSummary', {
request,
serviceName,
serviceEnvironment,
start,
end,
transactionType,
});

I think it will be more clean to use constants instead of string like apmServiceSummary. We could add them in observability_agent/common folder . Not blocking, just a thought :)

Otherwise, it looks nice. Thank you for making this change

@sorenlouv sorenlouv enabled auto-merge (squash) December 2, 2025 13:05
@sorenlouv sorenlouv marked this pull request as draft December 2, 2025 20:42
auto-merge was automatically disabled December 2, 2025 20:42

Pull request was converted to draft

@sorenlouv sorenlouv marked this pull request as ready for review December 2, 2025 20:42
@sorenlouv sorenlouv enabled auto-merge (squash) December 2, 2025 20:56
@sorenlouv sorenlouv merged commit 6d35204 into elastic:main Dec 3, 2025
13 checks passed
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
observabilityAgent 0 1 +1

History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team v9.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants