Skip to content

[Maps] Restore original ts-expect-error for complex style type intersection for BlendedVectorLayer #244867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −2
Open

[Maps] Restore original ts-expect-error for complex style type intersection for BlendedVectorLayer #244867

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ca5210
[Maps] Restore original ts-expect-error for complex style type inters…
olapawlus Dec 2, 2025
88615d4
Merge branch 'main' into fix/ts-expect-error-upgrade-ts-blended-vecto…
olapawlus Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ...ared/maps/public/classes/layers/vector_layer/blended_vector_layer/blended_vector_layer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,9 +149,10 @@ function getClusterStyleDescriptor(
),
}
: undefined;

clusterStyleDescriptor.properties[styleName] = {
type: STYLE_TYPE.DYNAMIC,
// @ts-expect-error upgrade typescript v5.1.6
// @ts-expect-error
Copy link
Member

@nickpeihl nickpeihl Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the thorough analysis. Do you mind adding a summarized reason to both @ts-expect-error?

Suggested change
// @ts-expect-error
// @ts-expect-error <description why we ignore type error>

options: {
...options,
field,
Expand All @@ -161,7 +162,7 @@ function getClusterStyleDescriptor(
// copy static styles to cluster style
clusterStyleDescriptor.properties[styleName] = {
type: STYLE_TYPE.STATIC,
// @ts-expect-error upgrade typescript v5.1.6
// @ts-expect-error
options: { ...styleProperty.getOptions() },
};
}
Expand Down
Loading