[Discover] [Unified Tabs] Add relative time info when tab was closed

[akowalska622]

Summary

Resolves: #244365

This pull request improves the handling and display of recently closed tabs in the TabsBarMenu component. The main changes include enhancing how closed timestamps are managed and displayed, and updating the UI to show relative time for closed tabs.

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

• Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
• Documentation was added for features that require explanation or tutorials
• Unit or functional tests were updated or added to match the most common scenarios
• If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
• This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
• Flaky Test Runner was used on any tests changed
• The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines
• Review the backport guidelines and apply applicable backport:* labels.

Identify risks

Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.

• See some risk examples
• ...

[akowalska622]

/ci

[elasticmachine]

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

[AlexGPlay]

do you need them to be findByTestId or can they be getByTestId?

Suggested change

	const menuButton = await screen.findByTestId(tabsBarMenuButtonTestId);
	await user.click(menuButton);
	expect(await screen.findByText('Recently closed')).toBeInTheDocument();
	expect(await screen.findByText(/5 minutes ago/i)).toBeInTheDocument();
	expect(await screen.findByText(/10 minutes ago/i)).toBeInTheDocument();
	const menuButton = screen.getByTestId(tabsBarMenuButtonTestId);
	await user.click(menuButton);
	expect(screen.getByTestId('Recently closed')).toBeInTheDocument();
	expect(screen.getByTestId(/5 minutes ago/i)).toBeInTheDocument();
	expect(screen.getByTestId(/10 minutes ago/i)).toBeInTheDocument();

[akowalska622]

Thanks for the suggestion Alex! Tbh I was just following the same pattern as the whole file is using. It's perfectly fine this way though, would you like me to update the whole file?

On a separate note - was replacing findByText by getByTestId too unintentional in your suggestion or it was on purpose?

[AlexGPlay]

No worries about the whole file, I guess this ones are fine for now 😄

Sorry no! I I just did a quick review and thought everything was byTestId - I guess it's just getByXX instead of findByXX 🙈

[akowalska622]

Thought so, thanks for clarifying 😁
I'll adjust the getter, thanks!

[akowalska622]

Addressed in 43acb5c

[elasticmachine]

💚 Build Succeeded

• Buildkite Build
• Commit: 43acb5c

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
discover	1.3MB	1.3MB	+336.0B
lens	1.6MB	1.6MB	+334.0B
total			+670.0B

History

• 💚 Build #368365 succeeded 4adf039
• 💔 Build #368176 failed 34444bc
• 💔 Build #367703 failed 8a4202e
• 💔 Build #367607 failed f92bbf9

cc @akowalska622