Skip to content

[Licensing] Relax requirement to populate kib-license-sig with latest ES value #244919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[Licensing] Relax requirement to populate kib-license-sig with latest ES value #244919

wants to merge 3 commits into from
+74 −30

Conversation

@jloleysens
Copy link
Contributor

@jloleysens jloleysens commented Dec 2, 2025 •
edited
Loading

Summary

PoC updating the license response interceptor to not block requests on retrieving a current license for kbn-license-sig header.

Assumptions & risks

  • Having the current kib-license-sig header at all times is not necessary
  • Returning a place holder value like unknown is OK. If this is wrong we may break some downstream dependency, albeit for a short window of time
  • Responding with a stale reference to a license sig is OK for the small subset of APIs in Kibana that do not rely on ES

Closes #244920

@jloleysens jloleysens self-assigned this Dec 2, 2025
@jloleysens jloleysens added Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// Feature:License release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting labels Dec 2, 2025
@jloleysens jloleysens changed the title relax license header in response dep [Licensing] Relax requirement to populate kib-license-sig with latest ES value Dec 2, 2025
jloleysens
jloleysens commented Dec 2, 2025
View reviewed changes
x-pack/platform/plugins/shared/licensing/server/on_pre_response_handler.ts
// situations.
if (res.statusCode >= 400 && res.statusCode !== 429) {
await refresh();
void refresh();
Copy link
Contributor Author

@jloleysens jloleysens Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One pitfall with this approach is that if the ES license ever changes and we are unable to get it for whatever reason Kibana will still report that last seen license in responses until we are able to asynchronously get an updated license from ES.

@jloleysens
Copy link
Contributor Author

jloleysens commented Dec 2, 2025

/ci

@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 2, 2025

💚 Build Succeeded

Metrics [docs]

✅ unchanged

cc @jloleysens

@jloleysens jloleysens marked this pull request as ready for review December 3, 2025 14:41
@jloleysens jloleysens requested a review from a team as a code owner December 3, 2025 14:41
@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 3, 2025

Pinging @elastic/kibana-core (Team:Core)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jloleysens jloleysens

Labels

backport:skip This PR does not require backporting Feature:License release_note:skip Skip the PR/issue when compiling release notes Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t//

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Licensing] Relax requirement to populate kib-license-sig with latest ES value

2 participants

@jloleysens @elasticmachine