-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[Fleet] Fix "Learn More" link to open in new tab #244945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Copilot
wants to merge
3
commits into
main
Choose a base branch
from
copilot/fix-learn-more-button-behavior
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "Learn More" button in the Fleet privileges callout now opens in a new browser tab/window instead of the same tab. This change adds the target="_blank" attribute to the EuiLink component, following the pattern used in other external links throughout the Fleet plugin. Co-authored-by: nchaulet <[email protected]>
Copilot
AI
changed the title
[WIP] Fix 'Learn More' button to open link in new window
[Fleet] Fix "Learn More" link to open in new tab
Dec 2, 2025
Copilot finished work on behalf of
nchaulet
December 2, 2025 16:15
nchaulet
approved these changes
Dec 2, 2025
Member
nchaulet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Member
|
/ci |
Member
|
/run docs-build |
Member
|
@elasticmachine merge upstream |
Member
|
/ci |
1 similar comment
Member
|
/ci |
Member
|
/run docs-build |
Contributor
💔 Build Failed
Failed CI StepsTest Failures
Metrics [docs]
History
cc @nchaulet @Copilot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:skip
This PR does not require backporting
💝community
release_note:skip
Skip the PR/issue when compiling release notes
Team:Fleet
Team label for Observability Data Collection Fleet team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The "Learn More" link in the Fleet privileges callout was opening in the same tab instead of a new window, disrupting user navigation context.
Added
target="_blank"to the EuiLink component rendering the documentation link. This aligns with the pattern used across all other external links in the Fleet plugin.Change:
Checklist
release_note:breakinglabel should be applied in these situations.release_note:*label is applied per the guidelinesbackport:*labels.Identify risks
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
ci-stats.kibana.dev/home/REDACTED/.nvm/versions/node/v22.17.1/bin/node /home/REDACTED/.nvm/versions/node/v22.17.1/bin/node --no-experimental-require-module scripts/kbn bootstrap --quiet(dns block)/home/REDACTED/.nvm/versions/node/v22.17.1/bin/node /home/REDACTED/.nvm/versions/node/v22.17.1/bin/node --no-experimental-require-module scripts/kbn clean(dns block)/home/REDACTED/.nvm/versions/node/v22.17.1/bin/node /home/REDACTED/.nvm/versions/node/v22.17.1/bin/node --no-experimental-require-module scripts/kbn bootstrap --force-install(dns block)download.cypress.io/home/REDACTED/.nvm/versions/node/v22.17.1/bin/node /home/REDACTED/.nvm/versions/node/v22.17.1/bin/node index.js --exec install(dns block)googlechromelabs.github.io/home/REDACTED/.nvm/versions/node/v22.17.1/bin/node /home/REDACTED/.nvm/versions/node/v22.17.1/bin/node install.js(dns block)iojs.org/usr/bin/curl curl -q --fail --compressed -L -s REDACTED -o -(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.