Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 2, 2025

Summary

The "Learn More" link in the Fleet privileges callout was opening in the same tab instead of a new window, disrupting user navigation context.

Added target="_blank" to the EuiLink component rendering the documentation link. This aligns with the pattern used across all other external links in the Fleet plugin.

Change:

// Before
<EuiLink href={docLinks.links.fleet.roleAndPrivileges} external>

// After  
<EuiLink href={docLinks.links.fleet.roleAndPrivileges} external target="_blank">

Checklist

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines
  • Review the backport guidelines and apply applicable backport:* labels.

Identify risks

  • No risks. Single attribute addition to existing link element with no logic changes.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • ci-stats.kibana.dev
    • Triggering command: /home/REDACTED/.nvm/versions/node/v22.17.1/bin/node /home/REDACTED/.nvm/versions/node/v22.17.1/bin/node --no-experimental-require-module scripts/kbn bootstrap --quiet (dns block)
    • Triggering command: /home/REDACTED/.nvm/versions/node/v22.17.1/bin/node /home/REDACTED/.nvm/versions/node/v22.17.1/bin/node --no-experimental-require-module scripts/kbn clean (dns block)
    • Triggering command: /home/REDACTED/.nvm/versions/node/v22.17.1/bin/node /home/REDACTED/.nvm/versions/node/v22.17.1/bin/node --no-experimental-require-module scripts/kbn bootstrap --force-install (dns block)
  • download.cypress.io
    • Triggering command: /home/REDACTED/.nvm/versions/node/v22.17.1/bin/node /home/REDACTED/.nvm/versions/node/v22.17.1/bin/node index.js --exec install (dns block)
  • googlechromelabs.github.io
    • Triggering command: /home/REDACTED/.nvm/versions/node/v22.17.1/bin/node /home/REDACTED/.nvm/versions/node/v22.17.1/bin/node install.js (dns block)
  • iojs.org
    • Triggering command: /usr/bin/curl curl -q --fail --compressed -L -s REDACTED -o - (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

This section details on the original issue you should resolve

<issue_title>[Fleet]: 'Learn More' button on Fleet tab opens in same window instead of new window.</issue_title>
<issue_description>Kibana Build details:

- VERSION: 9.3.0-SNAPSHOT
- BUILD: 93055
- COMMIT: 96ffcd79c2227e2236811a820f456044b691b2a4

Preconditions:

  1. 9.3.0-SNAPSHOT Kibana cloud environment should be available.
  2. Fleet privileges note should be present.

Steps to reproduce:

  1. Navigate to Fleet Tab.
  2. Observe the Fleet privileges note displayed at the top of the Fleet tab and click the Learn More button at the end of the note.
  3. Observe that the Learn More link opens in the same browser tab.

Expected Result:

  • When the user clicks the Learn More button on the Fleet privileges note, the corresponding link should open in a new browser tab or window.

Screen Capture:

Learn.more.link.is.not.opening.in.new.window.while.other.links.are.working.fine.mp4

What's Working:

  • All links on the Fleet tab are opening in a new browser tab or window as expected.
    </issue_description>

<agent_instructions>Add a target="_blank" to x-pack/platform/plugins/shared/fleet/public/applications/fleet/layouts/default/default.tsx#L133 </agent_instructions>

Comments on the Issue (you are @copilot in this section)

@elasticmachine Pinging @elastic/fleet (Team:Fleet) @amolnater-qasource Secondary review for this ticket is Done.

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

The "Learn More" button in the Fleet privileges callout now opens in a new browser tab/window instead of the same tab. This change adds the target="_blank" attribute to the EuiLink component, following the pattern used in other external links throughout the Fleet plugin.

Co-authored-by: nchaulet <[email protected]>
Copilot AI changed the title [WIP] Fix 'Learn More' button to open link in new window [Fleet] Fix "Learn More" link to open in new tab Dec 2, 2025
Copilot AI requested a review from nchaulet December 2, 2025 16:15
Copilot finished work on behalf of nchaulet December 2, 2025 16:15
@nchaulet nchaulet marked this pull request as ready for review December 2, 2025 16:18
@nchaulet nchaulet requested a review from a team as a code owner December 2, 2025 16:18
Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Dec 2, 2025
@nchaulet nchaulet added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting labels Dec 2, 2025
@nchaulet
Copy link
Member

nchaulet commented Dec 2, 2025

/ci

@nchaulet
Copy link
Member

nchaulet commented Dec 2, 2025

/run docs-build

@nchaulet
Copy link
Member

nchaulet commented Dec 2, 2025

@elasticmachine merge upstream

@nchaulet
Copy link
Member

nchaulet commented Dec 2, 2025

/ci

1 similar comment
@nchaulet
Copy link
Member

nchaulet commented Dec 2, 2025

/ci

@nchaulet
Copy link
Member

nchaulet commented Dec 2, 2025

/run docs-build

@elasticmachine
Copy link
Contributor

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #41 / lens app - group 2 lens layer actions tests should add a new visualization layer and disable the sampling if max operation is chosen
  • [job] [logs] FTR Configs #101 / saved objects management apis relationships should work for index patterns

Metrics [docs]

‼️ ERROR: no builds found for mergeBase sha [87bc4df]

History

cc @nchaulet @Copilot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting 💝community release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Fleet]: 'Learn More' button on Fleet tab opens in same window instead of new window.

4 participants