[agent builder] agent workflow step #244957
Open
+324
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppisljar
added
release_note:skip
…nto feature/onechat-workflow-step # Conflicts: # x-pack/platform/plugins/shared/onechat/server/step_types/run_agent_step.ts
semd
reviewed
Dec 3, 2025
Comment on lines
+34
to
+42
| /** | ||
| * Output schema for the run agent step. | ||
| */ | ||
| export const OutputSchema = z.object({ | ||
| /** | ||
| * The agent's response message. | ||
| */ | ||
| output: z.union([z.string(), z.any()]), | ||
| }); |
Contributor
There was a problem hiding this comment.
The output property is already set by the execution engine, this will make the step agent response be inside step.agent.output.output.
Maybe it would be better to just do:
Suggested change
| /** | |
| * Output schema for the run agent step. | |
| */ | |
| export const OutputSchema = z.object({ | |
| /** | |
| * The agent's response message. | |
| */ | |
| output: z.union([z.string(), z.any()]), | |
| }); | |
| /** | |
| * Output schema for the run agent step. | |
| */ | |
| export const OutputSchema = z.union([z.string(), z.any()]); |
semd
reviewed
Dec 3, 2025
Comment on lines
+28
to
+31
| /** | ||
| * The user input message to send to the agent. | ||
| */ | ||
| input: z.string(), |
Contributor
There was a problem hiding this comment.
NIT: Similar, we will have step.agent.input.input, maybe better to use message?
Contributor
💔 Build Failed
Failed CI StepsHistory
|
jbudz
reviewed
Dec 3, 2025
| observabilityOnboarding: 12872 | ||
| observabilityShared: 75115 | ||
| onechat: 25223 | ||
| onechat: 88464 |
Member
There was a problem hiding this comment.
Are we able to bring this back down?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
resolves https://github.com/elastic/search-team/issues/11874